fix(tree): ensure chunkers use the correct schema when chunking edits - #28367
Open
Abram Sanderson (Abe27342) wants to merge 2 commits into
Open
Abram Sanderson (Abe27342) wants to merge 2 commits into
Abram Sanderson (Abe27342) wants to merge 2 commits into
Conversation
Pass each chunker's schema explicitly to its shared shape lookup callback and restore the fork/schema regression and Comparison Forest seed 1. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
github-actions
Bot
added
area: tools
area: dds
Copilot started reviewing on behalf of
Abram Sanderson (Abe27342)
October 1, 2026 18:11
View session
Abram Sanderson (Abe27342)
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The consumer-visible SharedTree fix needs the required changeset for release documentation.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Fixes forked SharedTree edits so chunking uses the fork’s current schema rather than its parent’s captured schema.
Changes:
- Passes each chunker’s schema into shape lookup.
- Updates custom chunker callbacks.
- Re-enables the minimized regression and fuzz seed 1.
| File | Description |
|---|---|
chunkTree.ts |
Makes schema lookup clone-aware. |
chunkedForest.spec.ts |
Updates test chunker callbacks. |
chunkEncodingEndToEnd.spec.ts |
Updates encoding test callback. |
treeCheckout.spec.ts |
Enables the fork/schema regression. |
topLevel.fuzz.spec.ts |
Restores Comparison Forest seed 1. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (60 lines, 5 files), I've queued these reviewers:
How this works
|
Abram Sanderson (Abe27342)
enabled auto-merge (squash)
October 1, 2026 18:57
Noah Encke (noencke)
approved these changes
Oct 2, 2026
Abram Sanderson (Abe27342)
disabled auto-merge
October 2, 2026 18:43
Contributor
Bundle size comparisonBase commit: Notable changesNo bundles changed by ≥ 500 bytes parsed. Per-bundle deltas
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
0xaf9("missing schema") when editing a fork after its parent's schema upgrade loses a rebase. The root cause here is thattryShapeFromNodeSchema(in the before of this PR) closed over the schema object when the chunker was initially created, meaning callingcloneon a chunker incorrectly coupled the schema used to encode a branch and its fork.The correct schema to use is already available to the chunker (passed in at
clonetime), so simply avoiding closing over it and passing the schema as an argument to the function inChunkersuffices to fix the bug. I've also renamed the function slightly for clarity (and to avoid shadowing the free function with the same name)Historical context