Skip to content

feat: add xmodem cp upload/download command #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
benallfree wants to merge 9 commits into
base: master
Choose a base branch
from
Draft

feat: add xmodem cp upload/download command #915

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bec2cd9
feat: xmodem copy (cp)
benallfree Apr 13, 2026
d04fdb8
feat: add round-trip XModem testing script for firmware path prefixes
benallfree Apr 13, 2026
88ebd98
feat: add unit tests for XModem
benallfree Apr 13, 2026
8fa1bed
feat: --ls
benallfree Apr 13, 2026
517bcb6
refactor: update exit calls to use meshtastic.util.our_exit for consi…
benallfree Apr 13, 2026
63e230d
fix: update packet number handling to use monotonic uint16 instead of…
benallfree Apr 13, 2026
4013031
Merge branch 'feat/xmodem-cp' into feat/xmodem-ls
benallfree Apr 13, 2026
25469fe
--upload and --download globbing
benallfree Apr 13, 2026
d8e5b88
refactor: remove __int__ and __ext__ tests and mentions
benallfree Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: --ls
  • Loading branch information
@benallfree
benallfree committed Apr 13, 2026
commit 8fa1bed97796f76760e2597ad0fd1ef96166d9f8
34 changes: 32 additions & 2 deletions meshtastic/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,17 @@ def onConnected(interface):
# Must turn off encryption on primary channel
interface.getNode(args.dest, **getNode_kwargs).turnOffEncryptionOnPrimaryChannel()

if args.ls is not None:
closeNow = True
remote_dir = args.ls
depth = int(getattr(args, "ls_depth", 0) or 0)
node = interface.localNode
rows = node.listDir(remote_dir, depth=depth)
if rows is None:
our_exit("listDir failed", 1)
for path, sz in rows:
print(f"{sz}\t{path}")

if args.cp:
closeNow = True
src, dst = args.cp
Expand Down Expand Up @@ -1906,14 +1917,33 @@ def addLocalActionArgs(parser: argparse.ArgumentParser) -> argparse.ArgumentPars
help=(
"Copy a file to or from the device via XModem. "
"Usage: --cp <src> <dst>. "
"If <src> is a local file it is uploaded to <dst> on the device. "
"If <src> starts with / it is downloaded from the device to <dst> locally. "
"If <src> is an existing local file it is uploaded to <dst> on the device. "
"Otherwise <src> is treated as a device path and downloaded to local <dst>. "
"Use /__ext__/ or /__int__/ prefixes to target external or internal flash."
),
nargs=2,
metavar=("SRC", "DST"),
)

group.add_argument(
"--ls",
help=(
"List files on the device under REMOTE_DIR via XMODEM MFLIST (requires matching firmware). "
"Output: size_bytes<TAB>path (one per line)."
),
nargs="?",
const="/",
default=None,
metavar="REMOTE_DIR",
)

group.add_argument(
"--ls-depth",
help="Max directory depth for --ls (0 = files in REMOTE_DIR only).",
type=int,
default=0,
)

return parser

def addRemoteActionArgs(parser: argparse.ArgumentParser) -> argparse.ArgumentParser:
Expand Down
Loading