Skip to content

A small offering of unit test coverage #595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nerdenator wants to merge 18 commits into
base: master
Choose a base branch
from
Open

A small offering of unit test coverage #595

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5d11ca7
Increasing unit test line coverage a bit for some of the BLE classes;…
nerdenator Jun 14, 2024
3513d1b
Taking linter feedback into account.
nerdenator Jun 14, 2024
3ec7b96
Because GHA is hanging on the final test, I'm commenting it out, and …
nerdenator Jun 14, 2024
f0a7e93
Linting feedback
nerdenator Jun 14, 2024
15770cd
Trying to kick off new build to test things again.
nerdenator Jun 18, 2024
a348a70
Hanging test job again, so eliminating another test to see if it's th…
nerdenator Jun 18, 2024
fc55e79
Fixing lint problems
nerdenator Jun 18, 2024
4842189
More diagnosing of problems with CI/CD
nerdenator Jun 18, 2024
473401a
ble_code_coverage_1: hanging on first test was due to an open client.…
nerdenator Jun 26, 2024
340a9c2
ble_code_coverage_1: trying to suss out the type of error being throw…
nerdenator Jun 26, 2024
445c03a
ble_code_coverage_1: linting
nerdenator Jun 26, 2024
5dad15c
ble_code_coverage_1: additional test cases for _sanitize_address
nerdenator Jun 26, 2024
1bb9128
ble_code_coverage_1: linting
nerdenator Jun 26, 2024
8f0af0d
ble_code_coverage_1: At a stopping point, need to understand the unde…
nerdenator Jun 26, 2024
387320f
Merge branch 'master' into ble_code_coverage_1
nerdenator Jul 8, 2024
2689110
ble_code_coverage_1: adding Linux tests for several new lines; removi…
nerdenator Jul 9, 2024
2f812cd
Merge remote-tracking branch 'upstream/master' into ble_code_coverage_1
nerdenator Jul 15, 2024
d02292a
ble_code_coverage_1: more attempts to get the remaining lines of code…
nerdenator Jul 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into ble_code_coverage_1
  • Loading branch information
@nerdenator
nerdenator authored Jul 8, 2024
commit 387320fe03f386e93e2c7ea89678587bf771d2fa
2 changes: 1 addition & 1 deletion meshtastic/ble_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def __init__(
logging.debug("BLE connected")
except BLEInterface.BLEError as e:
self.close()
our_exit(e.message, 1)
raise e

if self.client.has_characteristic(LEGACY_LOGRADIO_UUID):
self.client.start_notify(LEGACY_LOGRADIO_UUID, self.legacy_log_radio_handler)
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.