Skip to content

removing name argument from tools #9966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
fariza wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

removing name argument from tools #9966

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8131760
removing name argument from tools
fariza Dec 10, 2017
ba1ab48
docstring correction
fariza Dec 11, 2017
a107967
pep8 fix
Dec 14, 2017
7a02d51
fix docstring
Dec 15, 2017
ef686fc
docstring corrections
Jul 17, 2020
375c2f0
remove unused method
Jul 17, 2020
8695315
api changes
Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docstring correction
  • Loading branch information
@fariza Federico Ariza
fariza authored and Federico Ariza committed Jul 17, 2020
commit ba1ab48a313d32f8b98c9516dfd6ea92ac4d213d
4 changes: 2 additions & 2 deletions lib/matplotlib/backend_bases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3322,8 +3322,8 @@ def add_tool(self, tool_name, group, position=-1):

Parameters
----------
tool : tool_like
The tool to add, see `.ToolManager.get_tool`.
tool_name : str

@jklymak jklymak Feb 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an API change, isn't it?

@jklymak jklymak Feb 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As are the added args below? Not sure if they are a problem, but prob needs an Api change note

Name of the the tool to add, see `ToolManager.get_tool`.

@QuLogic QuLogic Dec 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double 'the'

group : str
The name of the group to add this tool to.
position : int, default: -1
Expand Down