Skip to content

[WiP] FIX/ENH: include (offset, on-off seq) as a valid pattern to the linestyle validator (fix #9792) #9797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
afvincent wants to merge 2 commits into from
Closed

[WiP] FIX/ENH: include (offset, on-off seq) as a valid pattern to the linestyle validator (fix #9792) #9797

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
612d6d0
add offset-onoffseq pattern to ls validation
afvincent Nov 16, 2017
ffd3434
update the relevant test
afvincent Nov 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
update the relevant test
  • Loading branch information
@afvincent
afvincent committed Nov 16, 2017
commit ffd3434891a779c3a43c3edc54352739cb61ad3d
10 changes: 7 additions & 3 deletions lib/matplotlib/tests/test_rcparams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,14 +375,18 @@ def generate_validator_testcases(valid):
(['1.23', '4.56'], (None, [1.23, 4.56])),
([1.23, 456], (None, [1.23, 456.0])),
([1, 2, 3, 4], (None, [1.0, 2.0, 3.0, 4.0])),
((-1, [1.23, 456]), (-1, [1.23, 456.0])),
((None, [1.23, 456]), (None, [1.23, 456.0])),
((9.87, [1.23, 456]), (9.87, [1.23, 456.0])),
((np.float128(1), [1.23, 4]), (1.0, [1.23, 4.0])),
),
'fail': (('aardvark', ValueError), # not a valid string
('dotted'.encode('utf-16'), ValueError), # even on PY2
((None, [1, 2]), ValueError), # (offset, dashes) != OK
((0, [1, 2]), ValueError), # idem
((-1, [1, 2]), ValueError), # idem
([1, 2, 3], ValueError), # sequence with odd length
(1.23, ValueError), # not a sequence
(("a", [1, 2]), ValueError), # wrong explicit offset
((1, [1, 2, 3]), ValueError), # odd length sequence
(([1, 2], 1), ValueError), # inverted offset/onoff
)
}
# Add some cases of bytes arguments that Python 2 can convert silently:
Expand Down