Skip to content

DOC: missing API docs from #8032 #8285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuLogic merged 3 commits into from
Mar 18, 2017
Merged

DOC: missing API docs from #8032 #8285

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b16705d
DOC: missing API docs from #8032
tacaswell Mar 13, 2017
8892fb2
DOC small tweaks to API doc on scaling dashes
NelleV Mar 16, 2017
27030ed
Merge pull request #20 from NelleV/tacaswell_doc_lw_scale_api_changes
tacaswell Mar 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions doc/api/api_changes/2017-02-06_TAC.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
Do not clip lw when scaling dashes
``````````````````````````````````

Slightly change the algorithm to no longer clip the scaling factor,
thus the patterns will continue to shrink at thin line widths. If the
line width is smaller than the effective pixel size, this may result
in dashed lines turning into solid gray lines. This also required

@afvincent afvincent Mar 13, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why gray?

@tacaswell tacaswell Mar 13, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line was implicitly black in my head when I wrote this.

slightly tweaking the default patterns for '--', ':', and '.-' so that
with the default line-width the final patterns would not change.

@afvincent afvincent Mar 13, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line-width <- line width? (to be consistent with the other utterances of the expression).

Beside, it is not totally true that the new default patterns are exactly the same as before (e.g. the dotted pattern that is not a 50 %-50 % pattern anymore). Maybe the sentence should just state that the default patterns were tweaked to remain similar with the default lw value as well as to avoid “cluttering” with line widths thiner than the previous clipping boundary.


There is no way to restore the old behavior

@afvincent afvincent Mar 13, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing period?