Repository navigation
Mailmap updates - #7127
Mailmap updates#7127
Conversation
|
@QuLogic : my entry is fine, thank you. |
|
@QuLogic mine is good, thanks! On Sun, Sep 18, 2016 at 8:20 AM, Adrien F. Vincent <notifications@github.com
Kristen M. Thyng |
|
@QuLogic Thanks for the note. Instead of listing me as "rasbt," it would look nicer if you could list me as Sebastian Raschka. Thanks! |
|
@QuLogic https://github.com/QuLogic This is fine, thank you! On 18 September 2016 at 06:20, Elliott Sales de Andrade <
|
|
My name could be listed as "Dan Hickstein" rather than just DanHickstein. Thanks! |
| Patrick Chen <pat.chen@mail.utoronto.ca> | ||
|
|
||
| Paul Hobson <pmhobson@gmail.com> | ||
| Paul Hobson <pmhobson@gmail.com> vagrant <vagrant@precise32.(none)> |
There was a problem hiding this comment.
Not sure what the vagrant part is. Did I push a commit from a VM along time ago?
Otherwise, this looks good to me.
There was a problem hiding this comment.
Yes, #2768. It is a rather generic name though, so we'd have to be careful no-one else uses it, or maybe not bother fixing that one commit's attribution.
There was a problem hiding this comment.
Oof. Sorry about that.
I'm ok with that commit not getting attributed to me.
The main thing I'm concerned about is that y'all (the core team) have as few headaches as possible. I'm on board with whatever you chose to do wit this.
| MinRK <benjaminrk@gmail.com> Min RK <minrk@kerbin.local> | ||
| Nelle Varoquaux <nelle.varoquaux@gmail.com> Varoquaux <nelle.varoquaux@gmail.com> | ||
|
|
||
| Moritz Beyreuther <random.seed@web.de> |
There was a problem hiding this comment.
Hi @QuLogic, funny to meet you again in this project :) (and not in obspy). If you do not mind, I would prefer the pseudonym mbyt as name instead.. I do it like this everywhere on github... Email is right.
There was a problem hiding this comment.
Sure, no problem. You've still got your name in ObsPy commits, but I realize now those're pretty old and all the new ones are this style.
| Eric Ma <ericmajinglong@gmail.com> <ericmjl@Erics-MacBook-Pro.local> | ||
| Eric Ma <ericmajinglong@gmail.com> <ericmjl@users.noreply.github.com> | ||
|
|
||
| Filipe <ocefpaf@gmail.com> |
There was a problem hiding this comment.
Filipe Fernandes ocefpaf@gmail.com
(Thanks for doing this @QuLogic.)
|
@QuLogic My entry's good. Thanks! |
|
|
||
| matthias <maluethi@protonmail.ch> | ||
| matthias <maluethi@protonmail.ch> <matthias.luethi@lhep.unibe.ch> | ||
|
|
There was a problem hiding this comment.
Matthias Lüthi maluethi@protonmail.ch matthias.luethi@lhep.unibe.ch
Thanks @QuLogic
|
|
||
| Levi Kilcher <levi.kilcher@nrel.gov> | ||
|
|
||
| Lion Krischer <krischer@geophysik.uni-muenchen.de> |
There was a problem hiding this comment.
+Lion Krischer lion.krischer@gmail.com krischer@geophysik.uni-muenchen.de
|
|
||
| J. Goutin <JGoutin@users.noreply.github.com> JGoutin <ginnungagap@free.fr> | ||
|
|
||
| Jack Kelly <jack-list@xlk.org.uk> Jack (aka Daniel) Kelly <daniel.kelly10@imperial.ac.uk> |
There was a problem hiding this comment.
Please could we change my line to:
Jack Kelly <jack.kelly@imperial.ac.uk>
Thank you!
| Hans Moritz Günther <moritz.guenther@gmx.de> | ||
|
|
||
| J. Goutin <JGoutin@users.noreply.github.com> JGoutin <ginnungagap@free.fr> | ||
|
|
There was a problem hiding this comment.
Please, could you change my line to:
J.Goutin JGoutin@users.noreply.github.com
Thanks
There was a problem hiding this comment.
Not sure I understand what you want different then?
There was a problem hiding this comment.
I just want removing the second mail address.
Thanks.
There was a problem hiding this comment.
I can leave it out if you don't want them associated, but note the second address already appears in commits alongside your username; this line ensures they're treated as the same person.
There was a problem hiding this comment.
This is OK for me. Thanks.
|
Looks good to me. |
|
@QuLogic Feel free to self-merge this. |
310d2f7 to
5e7f6e4
Compare
|
Updated with corrections from @DanHickstein, @ocefpaf, @JackKelly, @krischer, @maluethi, @mbyt, and @rasbt. Note that GitHub no longer hides outdated diffs on their new review comments, so be sure to check the final entry. Added @LindyBalboa and @TrishGillett from gitter. |
|
Mine looks good, thanks! |
|
Alright I'm gonna be a jerk and change my mind. After panning through and seeing that most go with the name (and Travis needing restarted anyways), I'll bite. Conner R. Phillips will work. Keep it simple and match the email I suppose. Thanks Elliott. |
|
@QuLogic Please could mine be listed as: Slav Basharov |
|
@QuLogic mine is good to go, thank you |
|
At the end of the month, I think I will merge this. We're at >80% response and many of the remaining haven't even been on GitHub in a while (publicly, at least.) |
|
Could my name be listed as Florian Le Bourdais? Regards, |
5e7f6e4 to
0837260
Compare
|
Hopefully last update with corrections from @LindyBalboa, @basharovV, and @flothesof. |
|
@QuLogic mine is also fine. Thanks! |
|
@QuLogic, thanks for all your work regarding the mailmap updates. I am unsure if I understand that here correctly. From our conversation above I assumed the Now, for me it looks like in 0837260 the entry was deleted completely from the list. Am I missing something? |
|
@mbyt Your commits are all correct; there's not really any need for your entry here. |
I'm pulling this back as far as possible to keep everything in sync; there may be some conflicts when propagating branches forward, but this version is intended to supersede all copies.
For those of you wondering why you are being tagged here, the
.mailmapfile ensures that you will be counted as a single person as part of matplotlib's GitHub stats. Please confirm that your name and email (the first entry on a line) are the way you want to be listed. As there are some layout changes to this file in this PR, you may want to check only the last commit which only contains the addition of your names.@mbyt