Skip to content

MNT: overhaul stale handling #4738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jenshnielsen merged 30 commits into from
Aug 14, 2015
Merged

MNT: overhaul stale handling #4738

Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
02158b1
FIX: attempting to draw marks figure as not-stale
tacaswell Jul 18, 2015
b0c3741
PEP: remove extra lines
tacaswell Jul 18, 2015
7f3ef65
FIX: do not propogate stale on animated artists
tacaswell Jul 23, 2015
a677634
MNT: Limit what propagates stale to figure
tacaswell Jul 23, 2015
6d6e39a
API: forbid changing figure of Artist instance
tacaswell Jul 23, 2015
1aec54b
MNT: do not re-trigger draws during draw
tacaswell Jul 23, 2015
1a58f17
DOC: added explanatory comments to example
tacaswell Jul 23, 2015
72c5ce2
FIX: make sure that offset boxes propagate axes
tacaswell Jul 31, 2015
4cc9a74
TST: don't reuse artists in tests
tacaswell Jul 31, 2015
b39fd90
FIX: protect against None child
tacaswell Jul 31, 2015
0b49a55
MNT: use direct callback for stale, not pchanged
tacaswell Aug 1, 2015
59eaad6
MNT: still only propagate True up the chain
tacaswell Aug 1, 2015
69b1b36
MNT: fix vanilla python repl hook
tacaswell Aug 1, 2015
770b8d5
FIX: remove excessive stale cleaning
tacaswell Aug 1, 2015
aa810b6
MNT: don't need try/except anymore
tacaswell Aug 1, 2015
0af89d7
FIX: fix stupid bug in pyplot
tacaswell Aug 1, 2015
14b5a36
FIX: don't push race condition on un-pickling
tacaswell Aug 1, 2015
252d7a7
MNT: make base draw_idle re-entrant
tacaswell Aug 6, 2015
a44b74d
FIX: fix documentation typos
tacaswell Aug 7, 2015
53e2db2
MNT: use no-op callback instead of None
tacaswell Aug 7, 2015
54e04d3
FIX: remove stale callback on pickling
tacaswell Aug 9, 2015
5bd4711
MNT: make figure use base-class __getstate__
tacaswell Aug 10, 2015
a48be9f
MNT: defaulting `Artist.stale_callback` to None
tacaswell Aug 10, 2015
13e7c09
FIX: stale propagation in artist without fig/ax
Aug 11, 2015
83ea020
MNT: make sorting out what to re-draw faster
tacaswell Aug 12, 2015
a5f5ab5
MNT: make set_animated smarter
tacaswell Aug 12, 2015
c75f75d
MNT: when blitting in make artist animated
tacaswell Aug 12, 2015
51cc0ca
MNT: set animated to blit state
tacaswell Aug 12, 2015
0e201f9
MNT: setting cmap/norm marks as stale
tacaswell Aug 12, 2015
25079bf
MNT: set_data on FigureImage marks as stale
tacaswell Aug 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
FIX: make sure that offset boxes propagate axes 
When setting the axes of an offset box to propagate to it's children.
  • Loading branch information
@tacaswell
tacaswell committed Jul 31, 2015
commit 72c5ce21e966dc6c5c52bd95e2c54666d5e0df92
13 changes: 13 additions & 0 deletions lib/matplotlib/offsetbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,13 @@ def set_figure(self, fig):
for c in self.get_children():
c.set_figure(fig)

@martist.Artist.axes.setter
def axes(self, ax):
# TODO deal with this better
martist.Artist.axes.fset(self, ax)

@WeatherGod WeatherGod Aug 7, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uhm, never seen this before, and the documentation is nil. What does this do?

@tacaswell tacaswell Aug 7, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how you call the base-class property setter function.

https://docs.python.org/2/howto/descriptor.html#properties

@WeatherGod WeatherGod Aug 7, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, so that's how you do that... good to know!

for c in self.get_children():
c.axes = ax

def contains(self, mouseevent):
for c in self.get_children():
a, b = c.contains(mouseevent)
Expand Down Expand Up @@ -663,6 +670,11 @@ def add_artist(self, a):
self._children.append(a)
if not a.is_transform_set():
a.set_transform(self.get_transform())
if self.axes is not None:
a.axes = self.axes
fig = self.figure
if fig is not None:
a.set_figure(fig)

def draw(self, renderer):
"""
Expand Down Expand Up @@ -1041,6 +1053,7 @@ def __init__(self, loc,
def set_child(self, child):
"set the child to be anchored"
self._child = child
child.axes = self.axes
self.stale = True

def get_child(self):
Expand Down