Repository navigation
Conversation
Member
|
This may conflict with #4079 |
Member
|
Thank you for the patch (with tests)! I am on my way to bed and don't have the bandwidth to do a more through review right now. |
Member
|
@yangineer #4079 also pops color. I think it takes care of present problems in a more comprehensive way. Please check it out. |
Author
|
Oops, how did I not see #4079? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greetings!
I added a fix to pop "color" off the kwargs list and assign it to c.
This fixes the skipping colors problem in Issue #3489.
I also added a image comparison test for the fix.