Repository navigation
Conversation
timhoffm
force-pushed
the
rcparams-remove-backend-key-usage
branch
2 times, most recently
from
October 17, 2026 07:03
f0c47d3 to
271de55
Compare
timhoffm
force-pushed
the
rcparams-remove-backend-key-usage
branch
from
October 17, 2026 08:36
271de55 to
9409506
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Working towards #31791.
This removes most internal usages of the 'backend' key (some usage in tests is still in place because I have to decide there whether we still want to test the key API).
It's conceptually a schematic replacement
rcParams._get('backend')->rcParams._backend- obtain raw backend valuex = rcParams['backend']->x = rcParams._get_backend_resolved()- obtain resoved backendrcParams['backend'] = x->rcParams._backend = x- store the value. Note that this write had no specific logic attatched. It's only be used to store the new backend value.Note: There have been some places writing
rcParamsDefault['backend']andrcParamsOrig['backend']. These were needed to synchronize and persist backend information even after resetting rcParams. That's not needed anymore and thus removed now that the backend information only exists once as class attribute onRcParams.Note2: In theory it would even be better to use
RcParams._backendrather than access via instancercParams._backendbackend. I've not done that for now, because it would complicate the PR. We may do this in a followup.AI Disclosure
No AI.
PR quality check