Repository navigation
DOC: Fix mouserotationstyle value for Shoemake's arcball - #32475
Merged
Merged
Conversation
QuLogic
approved these changes
Oct 13, 2026
iccir
pushed a commit
that referenced
this pull request
Oct 14, 2026
iccir
added a commit
that referenced
this pull request
Oct 14, 2026
…475-on-v3.11.x Backport PR #32475 on branch v3.11.x (DOC: Fix mouserotationstyle value for Shoemake's arcball)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
The "Rotation with mouse" section of
doc/api/toolkits/mplot3d/view_angles.rstsays Ken Shoemake's arcball is selected withmouserotationstyle: Shoemake. That value is rejected:Shoemakewas a valid value while #28841 was in review. Commit 89701eb ("Soften the arcball edge using a 'border' parameter") renamed the styles (arcball→sphere,Shoemake→arcball) and updated the validator, but missed this line. SoShoemakewas never valid in a release (3.10.0 already rejects it).The correct value is
arcball. That is what the code runs for this style (axes3d.py, theelse: # 'arcball'branch), and the rest of the page agrees: the summary table row, the example comment ('azel', 'trackball', 'sphere', or 'arcball') and the paragraph "Both arcballs (mouserotationstyle: sphereandmouserotationstyle: arcball)". The defaultmatplotlibrcand the 3.10 what's new usearcballtoo.This PR corrects it.
AI Disclosure
Claude Code (Claude Sonnet 5.5 (high) ) flagged this issue while reviewing docs.
PR quality check