Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
GridSpec.set_width_ratiosandset_height_ratiosupdate the ratios stored by aGridSpec, but existing Axes are not repositioned unless a layout engine runs or theirSubplotSpecis re-evaluated. This behavior is currently implicit and can be surprising when a setter is called after Axes have been created.This change documents that existing-Axes behavior in both setter docstrings and points users to the supported ways to apply the updated ratios.
Closes #31971
AI Disclosure
I used generative AI to help inspect the repository, identify the relevant issue, and proofread this description. I reviewed and verified the change and the test result myself.
PR quality check
Testing
./.venv/bin/pytest -q lib/matplotlib/tests/test_gridspec.py(7 passed)git diff --check