Conversation
scottshambaugh
approved these changes
Oct 1, 2026
scottshambaugh
left a comment
scottshambaugh
left a comment
Contributor
There was a problem hiding this comment.
Dead code cleanup is always a good thing, and private (well in Python it's "private", but I digress) functions hold no API guarantees. So any external use is at-risk that we shouldn't weigh in our decisions. LGTM!
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
After #32120, I can't find any internal callers to
FT2Font._render_glyph()nor the_PositionedBitmapclass.I found one project on GitHub that is relatively new and is using
_render_glyphdirectly.I'm not sure how aggressive we want to be about removing unused internal code. That said, all tests seem to pass.
AI Disclosure
Not used.
PR quality check