Skip to content

Add pie artist #32359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertoffmoura wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Add pie artist #32359

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
14258c7
Add pie artist
robertoffmoura Sep 16, 2026
d6c1f00
Wire wedges and shadows through pie artist
robertoffmoura Sep 16, 2026
cc56b3d
Wire texts to pie artist
robertoffmoura Sep 16, 2026
5a2f69a
Make Pie participate in layout and autoscaling
robertoffmoura Sep 16, 2026
8e46532
Convert indentation to spaces
robertoffmoura Sep 16, 2026
e461515
Run ruff format
robertoffmoura Sep 16, 2026
f8d8686
Create get_legend_handles protocol
robertoffmoura Sep 16, 2026
94d3703
Add deprecated PieContainer
robertoffmoura Sep 16, 2026
769d66d
Add What's new entry, next api changes entries
robertoffmoura Sep 16, 2026
650a4d8
Update .pyi files
robertoffmoura Sep 16, 2026
df5151f
Use Pie instead of PieContainer in _axes.pyi
robertoffmoura Sep 16, 2026
f010f97
Fix build documentation errors
robertoffmoura Sep 16, 2026
91f6ec7
Use correct PR number
robertoffmoura Sep 16, 2026
05fa8ff
Run python tools/boilerplate.py
robertoffmoura Sep 16, 2026
ec7146f
Fix import in lib/matplotlib/pyplot.py
robertoffmoura Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run python tools/boilerplate.py
  • Loading branch information
@robertoffmoura
robertoffmoura committed Sep 16, 2026
commit 05fa8ffd0d4c82bbdf89473553cde96a743871bb
6 changes: 3 additions & 3 deletions lib/matplotlib/pyplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
from matplotlib.container import (
BarContainer,
ErrorbarContainer,
PieContainer,

Check warning on line 133 in lib/matplotlib/pyplot.py

View workflow job for this annotation

GitHub Actions / ruff 

[rdjson] reported by reviewdog 🐶
`matplotlib.container.PieContainer` imported but unused

Raw Output:
message:"`matplotlib.container.PieContainer` imported but unused" location:{path:"/home/runner/work/matplotlib/matplotlib/lib/matplotlib/pyplot.py" range:{start:{line:133 column:9} end:{line:133 column:21}}} severity:WARNING source:{name:"ruff" url:"https://docs.astral.sh/ruff"} code:{value:"unused-import" url:"https://docs.astral.sh/ruff/rules/unused-import"} suggestions:{range:{start:{line:130 column:5} end:{line:135 column:6}} text:"from matplotlib.container import (\n        BarContainer,\n        ErrorbarContainer,\n        StemContainer,\n    )"}
StemContainer,
)
from matplotlib.figure import SubFigure
Expand Down Expand Up @@ -3988,7 +3988,7 @@
normalize: bool = True,
hatch: str | Sequence[str] | None = None,
data: DataParamType = None,
) -> PieContainer:
) -> Pie:

Check warning on line 3991 in lib/matplotlib/pyplot.py

View workflow job for this annotation

GitHub Actions / ruff 

[rdjson] reported by reviewdog 🐶
Undefined name `Pie`

Raw Output:
message:"Undefined name `Pie`" location:{path:"/home/runner/work/matplotlib/matplotlib/lib/matplotlib/pyplot.py" range:{start:{line:3991 column:6} end:{line:3991 column:9}}} severity:WARNING source:{name:"ruff" url:"https://docs.astral.sh/ruff"} code:{value:"undefined-name" url:"https://docs.astral.sh/ruff/rules/undefined-name"}

Check failure on line 3991 in lib/matplotlib/pyplot.py

View workflow job for this annotation

GitHub Actions / mypy 

[mypy] reported by reviewdog 🐶
Name "Pie" is not defined  [name-defined]

Raw Output:
lib/matplotlib/pyplot.py:3991: error: Name "Pie" is not defined  [name-defined]
return gca().pie(
x,
explode=explode,
Expand Down Expand Up @@ -4017,7 +4017,7 @@
# Autogenerated by boilerplate.py. Do not edit as changes will be lost.
@_copy_docstring_and_deprecators(Axes.pie_label)
def pie_label(
container: PieContainer,
pie: Pie,

Check warning on line 4020 in lib/matplotlib/pyplot.py

View workflow job for this annotation

GitHub Actions / ruff 

[rdjson] reported by reviewdog 🐶
Undefined name `Pie`

Raw Output:
message:"Undefined name `Pie`" location:{path:"/home/runner/work/matplotlib/matplotlib/lib/matplotlib/pyplot.py" range:{start:{line:4020 column:10} end:{line:4020 column:13}}} severity:WARNING source:{name:"ruff" url:"https://docs.astral.sh/ruff"} code:{value:"undefined-name" url:"https://docs.astral.sh/ruff/rules/undefined-name"}

Check failure on line 4020 in lib/matplotlib/pyplot.py

View workflow job for this annotation

GitHub Actions / mypy 

[mypy] reported by reviewdog 🐶
Name "Pie" is not defined  [name-defined]

Raw Output:
lib/matplotlib/pyplot.py:4020: error: Name "Pie" is not defined  [name-defined]
/,
labels: str | Sequence[str],
*,
Expand All @@ -4027,7 +4027,7 @@
alignment: str = "auto",
) -> list[Text]:
return gca().pie_label(
container,
pie,
labels,
distance=distance,
textprops=textprops,
Expand Down
Loading