Repository navigation
MNT: bump minimum python to 3.12 and minimum numpy to 2.0 - #31740
Conversation
|
Looks like I can't do this without also bumping the numpy version. If I read it right, minver can't find numpy 1.25 wheels for python 3.12. |
9b1905a to
29bbea0
Compare
|
I do like a diff that is more red than green 😎 |
|
If I understand correctly, PySide2 does not support Python 3.12+, but PyQt5 does. This should be reflected in the docs. |
|
But we have been testing it with py311. Apparently I already forgot the lines I removed just two days ago 🤦♀️ |
|
The doc failure is just the wx links. @timhoffm requesting your re-review because I made more code changes after your approval (all in a new commit). |
QuLogic
left a comment
There was a problem hiding this comment.
This needs an API change note as well.
pyside2 does not support python 3.12+
|
Thank you! |
PR summary
According to NEP29 we could drop python 3.11 last month, and it should be long gone by the time we release mpl 3.12. Support for numpy v1 could be dropped last September. Contourpy v1.2.1 was the first version to support numpy v2.
Also I am having complications with
warn_externalin another branch and dropping python 3.11 means I only need one solution for that!AI Disclosure
No AI used.
PR checklist