Repository navigation
Fixed inaccurate image placement and even more resampling bugs #31021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
89bbd1c
Fix making an image that is to be placed at a fractional pixel
ayshih 0ecf660
Fix affine resampling when using nearest-neighbor interpolation
ayshih d9d7d15
Fix the handling of image resampling beyond the image bounds
ayshih 2d37c64
Fix pixel alignment for PcolorImage and NonUniformImage
ayshih dd24e05
Switch to premultiplied space inside Agg for RGBA blending
ayshih 35ccd4c
Adjust to favor the left input pixel for nearest-neighbor interpolation
ayshih f1a1fb4
Bump rendering edges to fill axes when rendering affine non-NN interp…
ayshih ae239ea
Add four figure tests and changelog entry
ayshih 800185c
Adjust existing figure test and update baseline images
ayshih File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Adjust existing figure test and update baseline images
- Loading branch information
commit 800185c8002aaa9eab791781ea760bda5071f7af
There are no files selected for viewing
Binary file modified
BIN
+486 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_axes/extent_units.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
34 changes: 17 additions & 17 deletions
34
lib/matplotlib/tests/baseline_images/test_axes/imshow.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-3 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_axes/imshow_clip.pdf
Binary file not shown.
Binary file modified
BIN
-56 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_axes/imshow_clip.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
38 changes: 19 additions & 19 deletions
38
lib/matplotlib/tests/baseline_images/test_axes/imshow_clip.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-1.11 KB
(99%)
lib/matplotlib/tests/baseline_images/test_axes/specgram_angle_freqs.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-138 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_axes/specgram_angle_noise.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-572 Bytes
(99%)
lib/matplotlib/tests/baseline_images/test_axes/specgram_freqs.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-572 Bytes
(99%)
lib/matplotlib/tests/baseline_images/test_axes/specgram_freqs_linear.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+338 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_axes/specgram_magnitude_freqs.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+338 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_axes/specgram_magnitude_freqs_linear.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-295 Bytes
(99%)
lib/matplotlib/tests/baseline_images/test_axes/specgram_magnitude_noise.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-295 Bytes
(99%)
lib/matplotlib/tests/baseline_images/test_axes/specgram_magnitude_noise_linear.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-345 Bytes
(99%)
lib/matplotlib/tests/baseline_images/test_axes/specgram_noise.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-345 Bytes
(99%)
lib/matplotlib/tests/baseline_images/test_axes/specgram_noise_linear.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-509 Bytes
(99%)
lib/matplotlib/tests/baseline_images/test_axes/specgram_phase_freqs.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-8 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_axes/specgram_phase_noise.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-908 Bytes
(97%)
lib/matplotlib/tests/baseline_images/test_axes/use_colorizer_keyword.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+7 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_bbox_tight/bbox_inches_inset_rasterized.pdf
Binary file not shown.
Binary file modified
BIN
+3 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_extend_alpha.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-12 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_colorbar/colorbar_keeping_xlabel.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+999 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_colors/light_source_shading_topo.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+46 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_colors/test_norm_abc.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+426 Bytes
(120%)
...lib/tests/baseline_images/test_constrainedlayout/test_colorbars_no_overlapH.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+919 Bytes
(130%)
...lib/tests/baseline_images/test_constrainedlayout/test_colorbars_no_overlapV.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+181 Bytes
(110%)
...ts/baseline_images/test_constrainedlayout/test_compressed_suptitle_colorbar.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+115 Bytes
(100%)
...s/baseline_images/test_constrainedlayout/test_compressed_supylabel_colorbar.png
Oops, something went wrong.
Binary file modified
BIN
+27 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_image/bbox_image_inverted.pdf
Binary file not shown.
Binary file modified
BIN
-42 Bytes
(99%)
lib/matplotlib/tests/baseline_images/test_image/bbox_image_inverted.png
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
+131 KB
(150%)
lib/matplotlib/tests/baseline_images/test_image/downsampling.png
Oops, something went wrong.
Binary file modified
BIN
-365 Bytes
(90%)
lib/matplotlib/tests/baseline_images/test_image/downsampling_speckle.png
Oops, something went wrong.
Binary file modified
BIN
-4 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_image/image_alpha.pdf
Binary file not shown.
Binary file modified
BIN
+107 Bytes
(100%)
lib/matplotlib/tests/baseline_images/test_image/image_alpha.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it really true that there are 10 bars on the left of the Axes instead of 8 now?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #31021 (comment) for my explanation. The severe aliasing changes appearance because the downsampling is both shifted and spaced differently (because of the removal of the enlarging step), so the number of bars is not particularly important.