Skip to content

Improving error message for width and position type mismatch in violinplot #30752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcomer merged 16 commits into from
Jan 25, 2026
Merged

Improving error message for width and position type mismatch in violinplot #30752

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7b44fcb
Improving error message for width and position type mismatch in violi…
hasanrashid Nov 16, 2025
4d9c8cd
Improving error message for width and position type mismatch in violi…
hasanrashid Nov 16, 2025
555f4d5
Merge branch 'enh-30417-v1' of github.com:hasanrashid/matplotlib into…
hasanrashid Nov 16, 2025
c40820b
Fix violin plot statistics in test data
hasanrashid Nov 29, 2025
2cb8aba
Trigger CI pipeline
hasanrashid Dec 7, 2025
8ff4f12
Trigger CI pipeline
hasanrashid Dec 7, 2025
b0862b8
Merge branch 'enh-30417-v1' of github.com:hasanrashid/matplotlib into…
hasanrashid Dec 15, 2025
cb23c70
Update lib/matplotlib/axes/_axes.py
hasanrashid Dec 21, 2025
8b3e2fd
Update lib/matplotlib/axes/_axes.py
hasanrashid Dec 21, 2025
07a4119
Update lib/matplotlib/tests/test_axes.py
hasanrashid Dec 21, 2025
4db1bf7
Store original widths parameter before conversion for accurate type v…
hasanrashid Dec 21, 2025
3e6bb85
Merge branch 'enh-30417-v1' of github.com:hasanrashid/matplotlib into…
hasanrashid Dec 21, 2025
82810c4
Update lib/matplotlib/axes/_axes.py
hasanrashid Dec 21, 2025
fa091cf
Update lib/matplotlib/axes/_axes.py
hasanrashid Dec 21, 2025
f03f086
Merge branch 'enh-30417-v1' of github.com:hasanrashid/matplotlib into…
hasanrashid Dec 22, 2025
94bcd9b
Remove low-information comment
rcomer Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/matplotlib/axes/_axes.py 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
  • Loading branch information
@hasanrashid
hasanrashid and Copilot authored Dec 21, 2025
commit 8b3e2fdeff72fdf33c10635b4663e043e28511fb
3 changes: 2 additions & 1 deletion lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9066,7 +9066,8 @@
if (isinstance(pos0, (datetime.datetime, datetime.date))
and not isinstance(width0, datetime.timedelta)):
raise TypeError(
"datetime/date 'position' values, require timedelta 'widths'")
"datetime/date 'position' values require timedelta 'widths'. "
"For example, use positions=[datetime.date(2024, 1, 1)] and widths=[datetime.timedelta(days=1)].")
elif (isinstance(pos0, np.datetime64)
and not isinstance(width0, np.timedelta64)):
raise TypeError(
Expand Down Expand Up @@ -9146,7 +9147,7 @@
bodies = []
bodies_zip = zip(vpstats, positions, widths, facecolor)
for stats, pos, width, facecolor in bodies_zip:
# The 0.5 factor reflects the fact that we plot from v-p to v+p.

Check warning on line 9150 in lib/matplotlib/axes/_axes.py

View workflow job for this annotation

GitHub Actions / ruff 

[rdjson] reported by reviewdog 🐶
Line too long (114 > 88)

Raw Output:
message:"Line too long (114 > 88)"  location:{path:"/home/runner/work/matplotlib/matplotlib/lib/matplotlib/axes/_axes.py"  range:{start:{line:9150  column:89}  end:{line:9150  column:115}}}  severity:WARNING  source:{name:"ruff"  url:"https://docs.astral.sh/ruff"}  code:{value:"E501"  url:"https://docs.astral.sh/ruff/rules/line-too-long"}
vals = np.array(stats['vals'])
vals = 0.5 * width * vals / vals.max()
bodies += [fill(stats['coords'],
Expand Down
Loading