Skip to content

Improving error message for width and position type mismatch in violinplot #30545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hasanrashid wants to merge 15 commits into from
Closed

Improving error message for width and position type mismatch in violinplot #30545

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
be9f788
Improving error message for width and position type mismatch in violi…
hasanrashid Sep 11, 2025
806b7be
Integrate tests in test_axes.py
hasanrashid Sep 30, 2025
c22a7a3
Bump mpl-sphinx-theme version
dstansby Sep 27, 2025
7935cce
Improve cursor icons with RectangleSelector
dstansby Aug 31, 2025
43fd154
Use an enum for RectangleSelector state
dstansby Sep 1, 2025
59f54c0
Improve signature of set_span_cursor
dstansby Sep 1, 2025
30adbc8
Improve variable naming
dstansby Sep 1, 2025
ce577fc
Add --debug flag to python -mmatplotlib.dviread CLI.
anntzer Sep 30, 2025
2245b1d
Include step info in str(scroll_event).
anntzer Sep 30, 2025
dd65c51
Update lib/matplotlib/axes/_axes.py
hasanrashid Oct 13, 2025
90806de
Merge branch 'matplotlib:main' into enh-30417
hasanrashid Oct 13, 2025
1e2bcae
Improving error message for width and position type mismatch in violi…
hasanrashid Sep 11, 2025
c5e3e0d
Integrate tests in test_axes.py
hasanrashid Sep 30, 2025
666fd6d
Update lib/matplotlib/axes/_axes.py
hasanrashid Oct 13, 2025
3119002
Merge branch 'enh-30417' of github.com:hasanrashid/matplotlib into en…
hasanrashid Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve variable naming
  • Loading branch information
@dstansby @hasanrashid
dstansby authored and hasanrashid committed Oct 2, 2025
commit 30adbc894ef2f61279cadee3e07c4d929b26955d
26 changes: 13 additions & 13 deletions lib/matplotlib/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3152,7 +3152,7 @@ def onselect(eclick: MouseEvent, erelease: MouseEvent)
"""


class _RectangleSelectorState(enum.Enum):
class _RectangleSelectorAction(enum.Enum):
ROTATE = enum.auto()
MOVE = enum.auto()
RESIZE = enum.auto()
Expand Down Expand Up @@ -3293,15 +3293,15 @@ def _press(self, event):
self._set_aspect_ratio_correction()

match self._get_action():
case _RectangleSelectorState.ROTATE:
case _RectangleSelectorAction.ROTATE:
# TODO: set to a rotate cursor if possible?
pass
case _RectangleSelectorState.MOVE:
case _RectangleSelectorAction.MOVE:
self._set_cursor(backend_tools.cursors.MOVE)
case _RectangleSelectorState.RESIZE:
case _RectangleSelectorAction.RESIZE:
# TODO: set to a resize cursor if possible?
pass
case _RectangleSelectorState.CREATE:
case _RectangleSelectorAction.CREATE:
self._set_cursor(backend_tools.cursors.SELECT_REGION)

return False
Expand Down Expand Up @@ -3357,13 +3357,13 @@ def _release(self, event):
def _get_action(self):
state = self._state
if 'rotate' in state and self._active_handle in self._corner_order:
return _RectangleSelectorState.ROTATE
return _RectangleSelectorAction.ROTATE
elif self._active_handle == 'C':
return _RectangleSelectorState.MOVE
return _RectangleSelectorAction.MOVE
elif self._active_handle:
return _RectangleSelectorState.RESIZE
return _RectangleSelectorAction.RESIZE

return _RectangleSelectorState.CREATE
return _RectangleSelectorAction.CREATE


def _onmove(self, event):
Expand All @@ -3383,7 +3383,7 @@ def _onmove(self, event):
action = self._get_action()

xdata, ydata = self._get_data_coords(event)
if action == _RectangleSelectorState.RESIZE:
if action == _RectangleSelectorAction.RESIZE:
inv_tr = self._get_rotation_transform().inverted()
xdata, ydata = inv_tr.transform([xdata, ydata])
eventpress.xdata, eventpress.ydata = inv_tr.transform(
Expand All @@ -3403,7 +3403,7 @@ def _onmove(self, event):

x0, x1, y0, y1 = self._extents_on_press
# rotate an existing shape
if action == _RectangleSelectorState.ROTATE:
if action == _RectangleSelectorAction.ROTATE:
# calculate angle abc
a = (eventpress.xdata, eventpress.ydata)
b = self.center
Expand All @@ -3412,7 +3412,7 @@ def _onmove(self, event):
np.arctan2(a[1]-b[1], a[0]-b[0]))
self.rotation = np.rad2deg(self._rotation_on_press + angle)

elif action == _RectangleSelectorState.RESIZE:
elif action == _RectangleSelectorAction.RESIZE:
size_on_press = [x1 - x0, y1 - y0]
center = (x0 + size_on_press[0] / 2, y0 + size_on_press[1] / 2)

Expand Down Expand Up @@ -3463,7 +3463,7 @@ def _onmove(self, event):
sign = np.sign(xdata - x0)
x1 = x0 + sign * abs(y1 - y0) * self._aspect_ratio_correction

elif action == _RectangleSelectorState.MOVE:
elif action == _RectangleSelectorAction.MOVE:
x0, x1, y0, y1 = self._extents_on_press
dx = xdata - eventpress.xdata
dy = ydata - eventpress.ydata
Expand Down