Skip to content

Added conversion from datetime to float for position and width parameters in violin plots #30508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hasanrashid wants to merge 9 commits into from
Closed

Added conversion from datetime to float for position and width parameters in violin plots #30508

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
963ab32
Added conversion from datetime to float for position and width parame…
hasanrashid Sep 2, 2025
0f55315
Fix linting error by making lines shorter
hasanrashid Sep 3, 2025
7034a73
Fixing trailing whitespace
hasanrashid Sep 3, 2025
2065fd2
Adding some tests for new code coverage
hasanrashid Sep 6, 2025
2370aa2
pylint and ruff check errors fixed
hasanrashid Sep 6, 2025
de64e19
Added conversion from datetime to float for position and width parame…
hasanrashid Sep 2, 2025
64b9e4c
Merge branch 'matplotlib:main' into enh-30417
hasanrashid Sep 10, 2025
4d0398d
Improve error message for mismatched position and width types in viol…
hasanrashid Sep 11, 2025
5521da0
Merge branch 'enh-30417' of github.com:hasanrashid/matplotlib into en…
hasanrashid Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Added conversion from datetime to float for position and width parame… 
…ters in violinplot
  • Loading branch information
@hasanrashid
hasanrashid committed Sep 2, 2025
commit 963ab32162955a3abe816225b8f1084b4f272fab
19 changes: 18 additions & 1 deletion lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@
from matplotlib.axes._secondary_axes import SecondaryAxis
from matplotlib.container import BarContainer, ErrorbarContainer, StemContainer
from matplotlib.transforms import _ScaledRotation

import matplotlib.dates as mdates
import datetime
_log = logging.getLogger(__name__)


Expand Down Expand Up @@ -9051,6 +9052,22 @@ def violin(self, vpstats, positions=None, vert=None,
elif len(positions) != N:
raise ValueError(datashape_message.format("positions"))

#Checks if position is datetime; Converts to float if it is
if positions is not None:
positions = [
mdates.date2num(pos) if isinstance(pos, (datetime.datetime, datetime.date)) else pos
for pos in positions
]

#Check if width is provided as time difference; convert to days if it is
if widths is not None:
if np.isscalar(widths):
widths = [widths] * N
widths = [
w.days if isinstance(w, datetime.timedelta) else w
for w in widths
]

# Validate widths
if np.isscalar(widths):
widths = [widths] * N
Expand Down