Skip to content

fix #29410 Modifying Axes' position also alters the original Bbox object used for initialization #29411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 2 commits into from
Jan 10, 2025
Merged

fix #29410 Modifying Axes' position also alters the original Bbox object used for initialization #29411

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a6a65e
fix #29410
hu-xiaonan Jan 6, 2025
882c3f5
Update test_axes_set_position_external_bbox_unchanged to use figure c…
hu-xiaonan Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update test_axes_set_position_external_bbox_unchanged to use figure c… 
…omparison
  • Loading branch information
@hu-xiaonan
hu-xiaonan authored Jan 10, 2025
commit 882c3f576ad876f4b03401a1283b59114704589a
9 changes: 5 additions & 4 deletions lib/matplotlib/tests/test_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9583,11 +9583,12 @@ def test_bar_color_precedence():
assert mcolors.same_color(bar.get_facecolor(), 'green')


def test_axes_set_position_external_bbox_unchanged():
@check_figures_equal(extensions=['png'])
def test_axes_set_position_external_bbox_unchanged(fig_test, fig_ref):
# From #29410: Modifying Axes' position also alters the original Bbox
# object used for initialization
bbox = mtransforms.Bbox([[0.0, 0.0], [1.0, 1.0]])
fig = plt.figure()
ax = fig.add_axes(bbox)
ax.set_position([0.25, 0.25, 0.5, 0.5])
ax_test = fig_test.add_axes(bbox)
ax_test.set_position([0.25, 0.25, 0.5, 0.5])
assert (bbox.x0, bbox.y0, bbox.width, bbox.height) == (0.0, 0.0, 1.0, 1.0)
ax_ref = fig_ref.add_axes([0.25, 0.25, 0.5, 0.5])