Skip to content

Pybind11 cleanup - #28857

Merged
oscargus merged 3 commits into
matplotlib:mainfrom
QuLogic:pybind11-cleanup
Oct 10, 2024
Merged

oscargus merged 3 commits into
matplotlib:mainfrom
QuLogic:pybind11-cleanup

Conversation

@QuLogic

@QuLogic QuLogic commented Sep 21, 2024 •

Copy link
Copy Markdown
Member

PR summary

As a followup to #28856, we can now do some final cleanup:

  • drop all the old Python → C converters, and other helpers
  • also move py_converters_11.{cpp,h} into py_converters.{cpp,h}
  • remove NumPy as a build dependency

PR checklist

@QuLogic QuLogic added the CI: Run cibuildwheel Run wheel building tests on a PR label Sep 21, 2024
@github-actions github-actions Bot removed the CI: Run cibuildwheel Run wheel building tests on a PR label Sep 24, 2024
@QuLogic QuLogic mentioned this pull request Sep 24, 2024
13 tasks done
@QuLogic QuLogic linked an issue Sep 24, 2024 that may be closed by this pull request
13 tasks done
And merge the two files now that there are no old ones.
This should be replaced by pybind11 in all cases now.
@QuLogic QuLogic added this to the v3.10.0 milestone Oct 9, 2024
@oscargus
oscargus merged commit 592c123 into matplotlib:main Oct 10, 2024
@QuLogic
QuLogic deleted the pybind11-cleanup branch October 10, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNT]: Pybind11 transition plan

3 participants