Skip to content

Fix pickling of AxesWidgets. #28430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuLogic merged 5 commits into from
Jul 4, 2024
Merged

Fix pickling of AxesWidgets. #28430

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
22b6e0d
Fix pickling of AxesWidgets.
anntzer Jun 20, 2024
1326835
TST: move test that requires interactive backend to subprocess
tacaswell Jul 3, 2024
dead056
TYP: add new method to typestubs
tacaswell Jul 3, 2024
9d0420b
FIX: re-order connection logic on setting axes
tacaswell Jul 3, 2024
f6bb9ee
TST: skip on broken GHA environments
tacaswell Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
FIX: re-order connection logic on setting axes
  • Loading branch information
@tacaswell
tacaswell committed Jul 3, 2024
commit 9d0420b6a051c0f2f618d2ac319498f9d9b39fbd
5 changes: 4 additions & 1 deletion lib/matplotlib/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2573,10 +2573,13 @@ def __init__(self, ax, onselect, direction, *, minspan=0, useblit=False,

def new_axes(self, ax, *, _props=None, _init=False):
"""Set SpanSelector to operate on a new Axes."""
self.ax = ax
reconnect = False
if _init or self.canvas is not ax.figure.canvas:
Comment thread
tacaswell marked this conversation as resolved.
if self.canvas is not None:
self.disconnect_events()
reconnect = True
self.ax = ax
if reconnect:
self.connect_default_events()

# Reset
Expand Down