Skip to content

Separates edgecolor from hatchcolor #28104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 19 commits into from
Dec 29, 2024
Merged

Separates edgecolor from hatchcolor #28104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7b489af
separated hatchcolor from edgecolor in patches
r3kste Sep 1, 2024
ed55f09
fixed logic for inherit in collections
r3kste Sep 2, 2024
3155bc0
added a gallery example
r3kste Sep 10, 2024
905ed86
made suggested changes
r3kste Sep 16, 2024
7942afd
reverted use of `inherit`
r3kste Sep 16, 2024
219bb26
fixed the logic for inheriting from edgecolor
r3kste Sep 18, 2024
8e732fa
fixed docs and enhanced tests
r3kste Oct 11, 2024
67a54c3
Apply suggestions from code review
r3kste Nov 1, 2024
84e12fb
made suggested changes
r3kste Nov 3, 2024
5b3a1e6
minor fix
r3kste Nov 3, 2024
8454dfc
use 'edge' instead of 'inherit'
r3kste Nov 4, 2024
a3c80e0
fix rcsetup
r3kste Nov 4, 2024
253c7e4
enhanced docs and added note for follow-up PR
r3kste Nov 13, 2024
0754734
Made suggested changes
Impaler343 Dec 19, 2024
a74f2af
made suggested changes
r3kste Dec 19, 2024
91ae826
enhanced tests and minor fix in docs
r3kste Dec 19, 2024
a23c9c5
minor changes to docs
r3kste Dec 20, 2024
4dd0c2d
Changed wording and alt text
Impaler343 Dec 25, 2024
6b54933
Minor Fix
Impaler343 Dec 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
made suggested changes
  • Loading branch information
@r3kste @Impaler343
r3kste authored and Impaler343 committed Dec 22, 2024
commit 905ed8679f7fae54ad0a17318053aebb6dd5e178
2 changes: 1 addition & 1 deletion lib/matplotlib/backend_bases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,7 +690,7 @@ def __init__(self):
self._linewidth = 1
self._rgb = (0.0, 0.0, 0.0, 1.0)
self._hatch = None
self._hatch_color = (0.0, 0.0, 0.0, 1.0)
self._hatch_color = None
self._hatch_linewidth = rcParams['hatch.linewidth']
self._url = None
self._gid = None
Expand Down
7 changes: 3 additions & 4 deletions lib/matplotlib/collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,9 @@ def __init__(self, *,
self._face_is_mapped = None
self._edge_is_mapped = None
self._mapped_colors = None # calculated in update_scalarmappable
self._hatch_color = mpl.rcParams['hatch.color']
if self._hatch_color == 'inherit':
self._hatch_color = mpl.rcParams['patch.edgecolor']
self._hatch_color = mcolors.to_rgba(self._hatch_color)
if (hatch_color := mpl.rcParams['hatch.color']) == 'inherit':
hatch_color = mpl.rcParams['patch.edgecolor']
self._hatch_color = mcolors.to_rgba(hatch_color)
Comment thread
timhoffm marked this conversation as resolved.
self._hatch_linewidth = mpl.rcParams['hatch.linewidth']
self.set_facecolor(facecolors)
self.set_edgecolor(edgecolors)
Expand Down