Skip to content

Add a new orientation parameter to Violinplot and deprecate vert #27998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 4 commits into from
May 14, 2024
Merged

Add a new orientation parameter to Violinplot and deprecate vert #27998

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e0a39ce
add violin orientation param
saranti Apr 1, 2024
d99c8e0
fix broken tests
saranti Apr 17, 2024
f2b91b5
add tim's suggestion and fix docs
saranti Apr 20, 2024
bb34576
make violin's orientation default to vertical
saranti Apr 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
make violin's orientation default to vertical
  • Loading branch information
@saranti
saranti committed May 14, 2024
commit bb3457656b36313551bede4e6be056c22ca3ace0
6 changes: 3 additions & 3 deletions lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8371,7 +8371,7 @@ def violinplot(self, dataset, positions=None, vert=None,
The positions of the violins; i.e. coordinates on the x-axis for
vertical violins (or y-axis for horizontal violins).

vert : bool, default: True.
vert : bool, optional
.. deprecated:: 3.10
Use *orientation* instead.

Expand Down Expand Up @@ -8476,7 +8476,7 @@ def _kde_method(X, coords):

@_api.make_keyword_only("3.9", "vert")
def violin(self, vpstats, positions=None, vert=None,
orientation=None, widths=0.5, showmeans=False,
orientation='vertical', widths=0.5, showmeans=False,
showextrema=True, showmedians=False, side='both'):
"""
Draw a violin plot from pre-computed statistics.
Expand Down Expand Up @@ -8515,7 +8515,7 @@ def violin(self, vpstats, positions=None, vert=None,
The positions of the violins; i.e. coordinates on the x-axis for
vertical violins (or y-axis for horizontal violins).

vert : bool, default: True.
vert : bool, optional
.. deprecated:: 3.10
Use *orientation* instead.

Expand Down
2 changes: 1 addition & 1 deletion lib/matplotlib/axes/_axes.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -760,7 +760,7 @@ class Axes(_AxesBase):
positions: ArrayLike | None = ...,
*,
vert: bool | None = ...,
orientation: Literal["vertical", "horizontal"] | None = ...,
orientation: Literal["vertical", "horizontal"] = ...,
widths: float | ArrayLike = ...,
showmeans: bool = ...,
showextrema: bool = ...,
Expand Down