Skip to content

Update for checking whether colors have an alpha channel #27327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcomer merged 16 commits into from
Jan 6, 2025
Merged

Update for checking whether colors have an alpha channel #27327

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
0586383
Update _has_alpha_channel
landoskape Nov 15, 2023
9719b60
Update lib/matplotlib/colors.py
landoskape Nov 15, 2023
77e759f
Clarify comment explanation
landoskape Nov 15, 2023
5d7edca
Remove unnecessary check about is_color_like
landoskape Nov 21, 2023
e7220c8
update docstring for undefined case
landoskape Jan 3, 2025
0cf3612
Deprecate unused method
landoskape Jan 3, 2025
e2099e6
Remove unnecessary method
landoskape Jan 4, 2025
5ac2c0f
Flake formatting update
landoskape Jan 4, 2025
212363e
Don't specify what an undefined result does
landoskape Jan 4, 2025
73127eb
Recursive check which handles hex colors too
landoskape Jan 4, 2025
c3cf8d4
Whitespace
landoskape Jan 4, 2025
b81786c
Remove is_color_like check and explain
landoskape Jan 5, 2025
80d422d
Don't discuss undefined results
landoskape Jan 5, 2025
bbe6fa2
Remove test of undefined result
landoskape Jan 5, 2025
de5e42d
Spelling error
landoskape Jan 6, 2025
0813e13
improved grammar in comment
landoskape Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Whitespace
  • Loading branch information
@landoskape
landoskape committed Jan 4, 2025
commit c3cf8d41dd8ac52d2ec6f2f2588ed3c21518231e
6 changes: 5 additions & 1 deletion lib/matplotlib/colors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,10 @@ def _has_alpha_channel(c):

If *c* is not a valid color specifier, then the result is undefined.
"""
# If c isn't a color, this is undefined. Return False instead of raising.
if not is_color_like(c):
return False

@oscargus oscargus Nov 15, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One should probably check the code if this has already been called. Since this is a private method one can require that it is checked.

@landoskape landoskape Nov 15, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm sure I know how to do that or what you mean. Would you explain a little more?

(also, thanks for the comments, as always)

Comment thread
landoskape marked this conversation as resolved.
Outdated

# if c is a hex, it has an alpha channel when it has 4 (or 8) digits after '#'
if isinstance(c, str):
if c[0] == '#' and (len(c) == 5 or len(c) == 9):
Expand All @@ -251,7 +255,7 @@ def _has_alpha_channel(c):

# if it has length 2, it's a color/alpha tuple
# if the second element isn't None or the first element has length = 4
if len(c) == 2 and (c[1] is not None or _has_alpha_channel(c[0]):
if len(c) == 2 and (c[1] is not None or _has_alpha_channel(c[0])):
# example: ([0.5, 0.5, 0.5, 0.5], None) or ('r', 0.5)
return True

Expand Down