Skip to content

Allow user to specify colors in violin plots with constructor method #27304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 13 commits into from
Jan 30, 2025
Merged

Allow user to specify colors in violin plots with constructor method #27304

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c1190e6
Add color specification and pyi docs
landoskape Nov 10, 2023
4c6def1
edgecolor to linecolor, no more alpha
landoskape Jan 27, 2025
9ce5d12
Arg documentation
landoskape Jan 28, 2025
33d186b
completeness, formatting
landoskape Jan 28, 2025
9e97d6f
Default logic, docstring, straightforward testing
landoskape Jan 28, 2025
2d4c7b7
Spelling error
landoskape Jan 28, 2025
35f5c62
single "next color" for default face/line
landoskape Jan 28, 2025
8474cf1
Merge branch 'violin-plot-color' of https://github.com/landoskape/mat…
landoskape Jan 28, 2025
a206de8
clarify color specification
landoskape Jan 29, 2025
3998c6f
axes bug -- set with facecolor
landoskape Jan 29, 2025
f219c3f
direct comparison to source colors, face!=line
landoskape Jan 29, 2025
60343f5
adjust behavior for classic mode
landoskape Jan 30, 2025
e66e33a
Apply suggestions from code review
timhoffm Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
single "next color" for default face/line
  • Loading branch information
@landoskape
landoskape committed Jan 28, 2025
commit 35f5c626641c52e5ef179f1d0166407dbc352d62
6 changes: 4 additions & 2 deletions lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8753,6 +8753,10 @@ def cycle_color(color, alpha=None):
return color_list

# Convert colors to chain (number of colors can be different from len(vpstats))
if facecolor is None or linecolor is None:
if not mpl.rcParams['_internal.classic_mode']:
next_color = self._get_lines.get_next_color()

if facecolor is not None:
facecolor = cycle_color(facecolor)
else:
Expand All @@ -8761,7 +8765,6 @@ def cycle_color(color, alpha=None):
if mpl.rcParams['_internal.classic_mode']:
facecolor = cycle_color('y', alpha=default_facealpha)
else:
next_color = self._get_lines.get_next_color()
facecolor = cycle_color(next_color, alpha=default_facealpha)

if linecolor is not None:
Expand All @@ -8770,7 +8773,6 @@ def cycle_color(color, alpha=None):
if mpl.rcParams['_internal.classic_mode']:
linecolor = cycle_color('r')
else:
next_color = self._get_lines.get_next_color()
linecolor = cycle_color(next_color)

# Check whether we are rendering vertically or horizontally
Expand Down