Skip to content

Fix return type of get_plot_commands #25580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcomer merged 1 commit into from
Mar 30, 2023
+2 −2
Merged

Fix return type of get_plot_commands #25580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix return type of get_plot_commands 
The typing PR found that this was returning a generator [1], but this
was an error from #24000, as 3.6 and earlier returned a list.

[1] #24976 (comment)
  • Loading branch information
@QuLogic
QuLogic committed Mar 30, 2023
commit c201c8b59c3606f7dcb47f4ce5aa7b6780ab2a29
4 changes: 2 additions & 2 deletions lib/matplotlib/pyplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2066,8 +2066,8 @@ def get_plot_commands():
NON_PLOT_COMMANDS = {
'connect', 'disconnect', 'get_current_fig_manager', 'ginput',
'new_figure_manager', 'waitforbuttonpress'}
return (name for name in _get_pyplot_commands()
if name not in NON_PLOT_COMMANDS)
return [name for name in _get_pyplot_commands()
if name not in NON_PLOT_COMMANDS]


def _get_pyplot_commands():
Expand Down