Skip to content

FIX: do not cache exceptions #25470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 2 commits into from
Mar 15, 2023
Merged

FIX: do not cache exceptions #25470

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db0c7c3
FIX: do not cache exceptions
tacaswell Mar 15, 2023
01390c5
MNT: delete references to frame objects
tacaswell Mar 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
MNT: delete references to frame objects 
This is to help prevent reference cycles between the frames and the locals in
that frame.

While garbage collection should in most cases take care of this eventually, we
can help the interpreter out and break the cycle before we return.
  • Loading branch information
@tacaswell
tacaswell committed Mar 15, 2023
commit 01390c53fcc777207a5f2c9b93f1cf8d3799e9c7
2 changes: 2 additions & 0 deletions lib/matplotlib/_api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,4 +385,6 @@ def warn_external(message, category=None):
frame.f_globals.get("__name__", "")):
break
frame = frame.f_back
# premetively break reference cycle between locals and the frame
del frame
warnings.warn(message, category, stacklevel)
2 changes: 2 additions & 0 deletions lib/matplotlib/cbook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ def _get_running_interactive_framework():
if frame.f_code in codes:
return "tk"
frame = frame.f_back
# premetively break reference cycle between locals and the frame
del frame
macosx = sys.modules.get("matplotlib.backends._macosx")
if macosx and macosx.event_loop_is_running():
return "macosx"
Expand Down