Skip to content

Adds option to plot average in boxplot, besides the median #2520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miggaiowski wants to merge 6 commits into from
Closed

Adds option to plot average in boxplot, besides the median #2520

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
de5e40a
Adds option to plot average in boxplot, besides the median
miggaiowski Oct 15, 2013
d6bc727
Moved new args to the end of the arglist
miggaiowski Oct 15, 2013
02bd4ad
Added documentation as coding guide requires
miggaiowski Oct 15, 2013
42e8614
Split line to be under 80 chars long
miggaiowski Oct 15, 2013
c75c67a
Only calculate averages if necessary
miggaiowski Oct 15, 2013
d79c099
Remove whitespace
miggaiowski Oct 15, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only calculate averages if necessary
  • Loading branch information
@miggaiowski
miggaiowski committed Oct 15, 2013
commit c75c67a891f0c9177fc1cacfc09ccf59e3fac596
12 changes: 6 additions & 6 deletions lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3025,13 +3025,13 @@ def computeConfInterval(data, med, iq, bootstrap):
med = usermedians[i]

if averages:
# get average
avg = np.average(d)
# use input averages if available
if useraverages is not None and useraverages[i] is not None:
avg = useraverages[i]
else:
avg = np.average(d)


# replace with input averages if available
if useraverages is not None:
if useraverages[i] is not None:
avg = useraverages[i]

@tacaswell tacaswell Oct 15, 2013

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a minor point, but would it make more sense to re-arrange this logic so that the average is only computed if needed?

@miggaiowski miggaiowski Oct 15, 2013

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, diff on the way.

On Tue, Oct 15, 2013 at 12:25 PM, Thomas A Caswell <notifications@github.com

wrote:

In lib/matplotlib/axes/_axes.py:

@@ -2996,6 +3024,15 @@ def computeConfInterval(data, med, iq, bootstrap):
if usermedians[i] is not None:
med = usermedians[i]

  •        if averages:

  •            # get average

  •            avg = np.average(d)

  •            # replace with input averages if available

  •            if useraverages is not None:

  •                if useraverages[i] is not None:

  •                    avg = useraverages[i]

This is a minor point, but would it make more sense to re-arrange this
logic so that the average is only computed if needed?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2520/files#r6974227
.

Miguel Gaiowski

@tacaswell tacaswell Oct 15, 2013

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pep8 is going to complain about this white space

@miggaiowski miggaiowski Oct 15, 2013

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops

# get high extreme
iq = q3 - q1
Expand Down