Skip to content

Backport PR #24677 on branch v3.6.x (FIX: do not replace the Axes._children list object) #24680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tacaswell merged 1 commit into from
Dec 9, 2022
Merged

Backport PR #24677 on branch v3.6.x (FIX: do not replace the Axes._children list object) #24680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Backport PR #24677: FIX: do not replace the Axes._children list object 
Manual backport due to conflicts, which were just additional tests in
main from #23861, so simply removed these.
  • Loading branch information
@ksunden @rcomer
ksunden authored and rcomer committed Dec 9, 2022
commit fe900c59ea290b87796b736eb65fd1cbf38cdeed
2 changes: 1 addition & 1 deletion lib/mpl_toolkits/axes_grid1/parasite_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def draw(self, renderer):
self._children.extend(ax.get_children())

super().draw(renderer)
self._children = self._children[:orig_children_len]
del self._children[orig_children_len:]

def clear(self):
for ax in self.parasites:
Expand Down
11 changes: 11 additions & 0 deletions lib/mpl_toolkits/tests/test_axes_grid1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,3 +568,14 @@ def test_rgb_axes():
g = rng.random((5, 5))
b = rng.random((5, 5))
ax.imshow_rgb(r, g, b, interpolation='none')


def test_removal():
import matplotlib.pyplot as plt
import mpl_toolkits.axisartist as AA
fig = plt.figure()
ax = host_subplot(111, axes_class=AA.Axes, figure=fig)
col = ax.fill_between(range(5), 0, range(5))
fig.canvas.draw()
col.remove()
fig.canvas.draw()