Repository navigation
BUG: Fix boxplots with manual confidence intervals passed as a numpy array - #2447
Merged
mdboom merged 2 commits intoSep 30, 2013
Merged
Conversation
Member
|
Sorry -- I'm just seeing your comment now about sneaking this in before 1.3.1, so I never tagged it for that milestone. This looks fine, so I'm going to merge. It may just make it into 1.3.2 :) |
mdboom
added a commit
that referenced
this pull request
Sep 30, 2013
BUG: Fix boxplots with manual confidence intervals passed as a numpy array
Member
Author
|
thanks @mdboom ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main stuff
Basically, I had some of the user input validation logic incorrect for numpy arrays of confidence intervals on the boxplots. This is a very minor fix, with a test and baseline image.
Some of my tests are failing on something to do with fonts -- unrelated, AFAIK, to this PR. See:https://gist.github.com/phobson/6643701I think that might be triggering a Travis failure too.Hopefully this can sneak in before 1.3.1.
unimport stuff
Looking down the road a bit, I would like to propose splitting up
axes.boxplotinto two method:The idea here is that the first, high-level method calls the second. The second method allows users to place the elements of the boxplot where ever they want. But that's neither here nor there.