Skip to content

Simplest pyproject.toml containing build-system only #24102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tacaswell merged 7 commits into from
Oct 12, 2022
Merged

Simplest pyproject.toml containing build-system only #24102

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c127355
Simplest pyproject.toml containing [build-system] only
ianthomas23 Oct 5, 2022
54efcae
Don't use build isolation on minimum versions CI run
ianthomas23 Oct 7, 2022
b06715a
Temporarily pin setuptools in GHA
ianthomas23 Oct 8, 2022
bdfd2ff
Use local dir for build_temp if coverage enabled
ianthomas23 Oct 9, 2022
ff16e05
Edit matplotlibrc in place if editable mode install
ianthomas23 Oct 9, 2022
a925f04
Don't update matplotlibrc at all if editable_mode
ianthomas23 Oct 10, 2022
0e97a90
Improved comments
ianthomas23 Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Improved comments
  • Loading branch information
@ianthomas23
ianthomas23 committed Oct 11, 2022
commit 0e97a90a9c415c24186595ca1f5ed7c32f481a50
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import setuptools.command.build_py
import setuptools.command.sdist

# sys.path modified to find setupext.py during pyproject.toml builds.
sys.path.append(str(Path(__file__).resolve().parent))

import setupext
Expand Down Expand Up @@ -71,7 +72,7 @@ def has_flag(self, flagname):
class BuildExtraLibraries(setuptools.command.build_ext.build_ext):
def finalize_options(self):
# If coverage is enabled then need to keep the .o and .gcno files in a
# non-temporary directory otherwise coverage info is not collected.
# non-temporary directory otherwise coverage info not collected.
cppflags = os.getenv('CPPFLAGS')
if cppflags and '--coverage' in cppflags:
self.build_temp = 'build'
Expand Down