Repository navigation
[DOC]: adding a grid to the style sheet reference. - #24020
Merged
Merged
Conversation
kostyafarber
marked this pull request as draft
September 27, 2022 14:45
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Thank you for opening your first PR into Matplotlib!
If you have not heard from us in a while, please feel free to ping @matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.
You can also join us on gitter for real-time discussion.
For details on testing, writing docs, and our review process, please see the developer guide
We strive to be a welcoming and open project. Please follow our Code of Conduct.
kostyafarber
marked this pull request as ready for review
September 27, 2022 15:08
kostyafarber
changed the title
kostyafarber
changed the title
1 task
Co-authored-by: Kinza Raza <kanza.imran@careem.com>
kostyafarber
force-pushed
the
issue-23601
branch
from
September 27, 2022 17:12
f1812c1 to
d1fb720
Compare
Contributor
Author
|
Added @Kinza-Raza as co-author of commit. |
jklymak
reviewed
Sep 27, 2022
Member
|
Please title the commit/PR correctly. You are adding a grid to the style sheet reference, not a divider and annotation. The latter is an implementation detail of the former. |
Contributor
Author
|
No worries will change the PR title. |
kostyafarber
changed the title
Contributor
Author
|
@QuLogic changed the PR title. |
Contributor
Author
|
@jklymak let me know if I need to do anything else. Thanks! |
jklymak
reviewed
Sep 30, 2022
Co-authored-by: Jody Klymak <jklymak@gmail.com>
jklymak
reviewed
Sep 30, 2022
Co-authored-by: Jody Klymak <jklymak@gmail.com>
jklymak
approved these changes
Oct 1, 2022
Member
|
Thanks for your work and patience with this @kostyafarber . I think this looks good, and should be helpful for folks curious about what happens if they turn the grid on. |
ameligrana
pushed a commit
to ameligrana/matplotlib
that referenced
this pull request
Oct 18, 2022
* add divider and annotation. Co-authored-by: Kinza Raza <kanza.imran@careem.com> * fix flake8 * change from annotate to title * Update examples/style_sheets/style_sheets_reference.py Co-authored-by: Jody Klymak <jklymak@gmail.com> * Update examples/style_sheets/style_sheets_reference.py Co-authored-by: Jody Klymak <jklymak@gmail.com> Co-authored-by: Kinza Raza <kanza.imran@careem.com> Co-authored-by: Jody Klymak <jklymak@gmail.com>
melissawm
pushed a commit
to melissawm/matplotlib
that referenced
this pull request
Dec 19, 2022
* add divider and annotation. Co-authored-by: Kinza Raza <kanza.imran@careem.com> * fix flake8 * change from annotate to title * Update examples/style_sheets/style_sheets_reference.py Co-authored-by: Jody Klymak <jklymak@gmail.com> * Update examples/style_sheets/style_sheets_reference.py Co-authored-by: Jody Klymak <jklymak@gmail.com> Co-authored-by: Kinza Raza <kanza.imran@careem.com> Co-authored-by: Jody Klymak <jklymak@gmail.com>
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
* add divider and annotation. Co-authored-by: Kinza Raza <kanza.imran@careem.com> * fix flake8 * change from annotate to title * Update examples/style_sheets/style_sheets_reference.py Co-authored-by: Jody Klymak <jklymak@gmail.com> * Update examples/style_sheets/style_sheets_reference.py Co-authored-by: Jody Klymak <jklymak@gmail.com> Co-authored-by: Kinza Raza <kanza.imran@careem.com> Co-authored-by: Jody Klymak <jklymak@gmail.com>
imgbot Bot
pushed a commit
to kkipngenokoech/matplotlib
that referenced
this pull request
Apr 19, 2026
* add divider and annotation. Co-authored-by: Kinza Raza <kanza.imran@careem.com> * fix flake8 * change from annotate to title * Update examples/style_sheets/style_sheets_reference.py Co-authored-by: Jody Klymak <jklymak@gmail.com> * Update examples/style_sheets/style_sheets_reference.py Co-authored-by: Jody Klymak <jklymak@gmail.com> Co-authored-by: Kinza Raza <kanza.imran@careem.com> Co-authored-by: Jody Klymak <jklymak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR adds gridlines to the last plot in the stylesheets example and adds an annotation
ax.grid(True)as well as a divider to clearly distinguish between subplots. This addresses #23601PR Checklist
Tests and Styling
flake8-docstringsand runflake8 --docstring-convention=all).