Skip to content

FIX: only expect FigureCanvas on backend module if using new style #23912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oscargus merged 1 commit into from
Sep 17, 2022
Merged

FIX: only expect FigureCanvas on backend module if using new style #23912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
FIX: only expect FigureCanvas on backend module if using new style 
This is to un-break pycharm's backend_interagg

Closes #23911
  • Loading branch information
@tacaswell
tacaswell committed Sep 16, 2022
commit 0d37358ef36db828f623dfc7d2a0dbd892f52cf5
3 changes: 2 additions & 1 deletion lib/matplotlib/pyplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,6 @@ def switch_backend(newbackend):

backend_mod = importlib.import_module(
cbook._backend_module_name(newbackend))
canvas_class = backend_mod.FigureCanvas

required_framework = _get_required_interactive_framework(backend_mod)
if required_framework is not None:
Expand Down Expand Up @@ -293,6 +292,8 @@ class backend_mod(matplotlib.backend_bases._Backend):
# also update backend_mod accordingly; also, per-backend customization of
# draw_if_interactive is disabled.
if new_figure_manager is None:
# only try to get the canvas class if have opted into the new scheme
canvas_class = backend_mod.FigureCanvas
def new_figure_manager_given_figure(num, figure):
return canvas_class.new_manager(figure, num)

Expand Down