Skip to content

FIX: show bars when the first location is nan #23751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 2 commits into from
Sep 19, 2022
Merged

FIX: show bars when the first location is nan #23751

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfb27b3
FIX: show bars when the first location is nan
tacaswell Aug 26, 2022
bbf0cd2
MNT: shorten logic + docstring
tacaswell Sep 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
MNT: shorten logic + docstring
  • Loading branch information
@tacaswell
tacaswell committed Sep 13, 2022
commit bbf0cd2610eb253fdfee73276e0a57fb8a28851b
10 changes: 5 additions & 5 deletions lib/matplotlib/cbook/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1708,14 +1708,17 @@ def safe_first_element(obj):

def _safe_first_finite(obj, *, skip_nonfinite=True):
"""
Return the first non-None element in *obj*.
Return the first non-None (and optionally finite) element in *obj*.

This is a method for internal use.

This is an type-independent way of obtaining the first non-None element,
supporting both index access and the iterator protocol.
The first non-None element will be obtained when skip_none is True.
"""
def safe_isfinite(val):
if val is None:
return False
try:
return np.isfinite(val) if np.isscalar(val) else True
Comment thread
timhoffm marked this conversation as resolved.
except TypeError:
Expand Down Expand Up @@ -1743,10 +1746,7 @@ def safe_isfinite(val):
raise RuntimeError("matplotlib does not "
"support generators as input")
else:
return next(
val for val in obj
if val is not None and safe_isfinite(val)
)
return next(val for val in obj if safe_isfinite(val))


def sanitize_sequence(data):
Expand Down