Skip to content

Replace hardcoded parameter names when creating error bars #23376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wqian94 wants to merge 4 commits into from
Closed

Replace hardcoded parameter names when creating error bars #23376

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51d4959
Replace hardcoded parameter names when creating error bars
wqian94 Jun 30, 2022
9958432
Document API changes
wqian94 Jun 30, 2022
68d858c
Improve parameter passing detection using LineCollection parameters
wqian94 Jul 5, 2022
47205bc
Also include previously-rejected keys
wqian94 Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Also include previously-rejected keys
  • Loading branch information
@wqian94
wqian94 committed Jul 5, 2022
commit 47205bc3da81a4312aa87ba7028df16866a3b15e
10 changes: 8 additions & 2 deletions lib/matplotlib/axes/_axes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3454,8 +3454,14 @@ def _upcast_err(err):

# Eject anything that's not acceptable by LineCollection.set()
lc_keys = inspect.signature(mcoll.LineCollection.set).parameters
for key in tuple(base_style.keys()): # Because we're resizing base_style
if key not in lc_keys:
rej_keys = ['marker', 'markersize', 'markerfacecolor',
'markeredgewidth', 'markeredgecolor', 'markevery',
'linestyle', 'fillstyle', 'drawstyle', 'dash_capstyle',
'dash_joinstyle', 'solid_capstyle', 'solid_joinstyle',
'dashes']
# Because we're resizing base_style
for key in tuple(base_style.keys()):
if key not in lc_keys or key in rej_keys:
base_style.pop(key, None)

# Make the style dict for the line collections (the bars).
Expand Down