Skip to content

Fix TkAgg memory leaks and test for memory growth regressions #22002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tacaswell merged 15 commits into from
Apr 28, 2022
Merged

Fix TkAgg memory leaks and test for memory growth regressions #22002

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2056ce1
test figure creation memory leak
richardsheridan Dec 18, 2021
b59a89e
inspect running framework to decide if destroy should be delayed
richardsheridan Dec 18, 2021
a1f2e5f
bigger warmup for leak test
richardsheridan Apr 8, 2022
a3016af
clean up tkinter variable trace
richardsheridan Apr 8, 2022
e6e4cad
collect garbage aggressively after manager destruction
richardsheridan Apr 8, 2022
2829677
tune memory leak test
richardsheridan Apr 8, 2022
d50a68d
flake8
richardsheridan Apr 8, 2022
a082b32
remove manager from locals before gc collect
richardsheridan Apr 8, 2022
589038c
Revert "tune memory leak test"
richardsheridan Apr 8, 2022
1fd95d3
Revert full GC collect
richardsheridan Apr 13, 2022
09d420c
Revert tightening of thread safety test
richardsheridan Apr 13, 2022
44b55df
Loosen threshold to make CI pass
richardsheridan Apr 13, 2022
34d7183
Run garbage collection in leak test
QuLogic Apr 28, 2022
6c7ab77
Run flush events on wx only
QuLogic Apr 28, 2022
b2a3ce5
Increase leak threshold for macOS backend
QuLogic Apr 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bigger warmup for leak test
  • Loading branch information
@richardsheridan
richardsheridan committed Apr 8, 2022
commit a1f2e5ff919031bdb4d2aa272459d6dc5b474830
15 changes: 8 additions & 7 deletions lib/matplotlib/tests/test_backends_interactive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,21 +513,22 @@ def _test_figure_leak():
from matplotlib import pyplot as plt
# Second argument is pause length, but if zero we should skip pausing
t = float(sys.argv[1])
p = psutil.Process()

# Warmup cycle, this reasonably allocates a lot
p = psutil.Process()
fig = plt.figure()
if t:
plt.pause(t)
plt.close(fig)
mem = p.memory_full_info().uss
for _ in range(2):
fig = plt.figure()
if t:
plt.pause(t)
plt.close(fig)
mem = p.memory_info().rss

for _ in range(5):
fig = plt.figure()
if t:
plt.pause(t)
plt.close(fig)
Comment thread
QuLogic marked this conversation as resolved.
growth = p.memory_full_info().uss - mem
growth = p.memory_info().rss - mem

print(growth)

Expand Down