Skip to content

Clean up RectangleSelector move code #21921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 2 commits into from
Dec 12, 2021
Merged

Clean up RectangleSelector move code #21921

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff8195e
Remove un-used variables
dstansby Dec 10, 2021
6b3ea86
Cleaner logic in _onmove
dstansby Dec 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove un-used variables
  • Loading branch information
@dstansby
dstansby committed Dec 10, 2021
commit ff8195e131c41275ea7708e1d18297e0f3a43de3
3 changes: 0 additions & 3 deletions lib/matplotlib/widgets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3124,13 +3124,10 @@ def _onmove(self, event):
else:
# change sign of relative changes to simplify calculation
# Switch variables so that x1 and/or y1 are updated on move
x_factor = y_factor = 1
if 'W' in self._active_handle:
x0 = x1
x_factor *= -1
if 'S' in self._active_handle:
y0 = y1
y_factor *= -1
if self._active_handle in ['E', 'W'] + self._corner_order:
x1 = event.xdata
if self._active_handle in ['N', 'S'] + self._corner_order:
Expand Down