Skip to content

Remove ttconv and implement Type-42 embedding using fontTools #20866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ksunden merged 10 commits into from
Oct 16, 2024
Merged

Remove ttconv and implement Type-42 embedding using fontTools #20866

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e3bda66
Type-42 fonts using fontTools
jkseppan Aug 20, 2021
786f202
Remove ttconv
jkseppan Aug 20, 2021
566c2a6
Add several more droppable tables
jkseppan Aug 20, 2021
485e1b7
Don't crash if the loca table is missing
jkseppan Aug 20, 2021
f4a04c3
Don't crash if glyph bounds cannot be found
jkseppan Aug 20, 2021
94698fa
Log the name of unsupported fonts
jkseppan Aug 21, 2021
c6ab62b
Get names from the original font
jkseppan Aug 21, 2021
19e4679
Document ttconv removal
jkseppan Aug 21, 2021
9fa0b2b
Apply fixes from code review
QuLogic Sep 6, 2024
45a1654
Clean up some ttconv replacements
QuLogic Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Log the name of unsupported fonts 
FT2Font throws RuntimeError for some fonts
  • Loading branch information
@jkseppan @QuLogic
jkseppan authored and QuLogic committed Oct 16, 2024
commit 94698fa16388df088ce7ecd841eb9858afaf97ed
15 changes: 11 additions & 4 deletions lib/matplotlib/backends/_backend_pdf_ps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

from io import BytesIO
import functools
import logging

from fontTools import subset

Expand Down Expand Up @@ -177,7 +178,13 @@ def _get_font_afm(self, prop):

def _get_font_ttf(self, prop):
fnames = font_manager.fontManager._find_fonts_by_props(prop)
font = font_manager.get_font(fnames)
font.clear()
font.set_size(prop.get_size_in_points(), 72)
return font
try:
font = font_manager.get_font(fnames)
font.clear()
font.set_size(prop.get_size_in_points(), 72)
return font
except RuntimeError:
logging.getLogger(__name__).warning(
"The PostScript/PDF backend does not currently "
"support the selected font (%s).", fnames)
raise
2 changes: 1 addition & 1 deletion lib/matplotlib/backends/backend_ps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ def _font_to_ps_type42(font_path, chars, fh):
except RuntimeError:
_log.warning(
"The PostScript backend does not currently "
"support the selected font.")
"support the selected font (%s).", font_path)
raise


Expand Down