Skip to content

Implementing ticklabels keyword in plt.colorbar() #18884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danuo wants to merge 13 commits into from
Closed

Implementing ticklabels keyword in plt.colorbar() #18884

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
6936d2e
Implementing ticklabels keyword in plt.colorbar()
danuo Nov 3, 2020
553e26a
Adding testing routing for ticklabels in plt.colorbar()
danuo Nov 4, 2020
2d65c33
Adding keyword documentation of ticklabels in plt.colorbar()
danuo Nov 4, 2020
60e2b34
Make colorbar._ticklabels a private variable
danuo Nov 7, 2020
245936a
implement clear warnings for wrong ticks or ticklabels
danuo Nov 10, 2020
0ab998f
fix indent for flake8
danuo Nov 10, 2020
f09711a
fix line length
danuo Nov 10, 2020
b00d5de
fix failing tests
danuo Nov 13, 2020
58ebc94
implement more test cases
danuo Nov 13, 2020
7e6de18
whitespace fix
danuo Nov 13, 2020
6d58867
Fix regex expression with proper escape characters
danuo Nov 14, 2020
f993a3e
line length
danuo Nov 14, 2020
239f5ac
fix table margin in docstring
danuo Nov 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix line length
  • Loading branch information
@danuo
danuo committed Nov 10, 2020
commit f09711a83904ce45540dfd8c06d14ccec98b45ff
8 changes: 4 additions & 4 deletions lib/matplotlib/colorbar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -727,8 +727,8 @@ def set_ticklabels(self, ticklabels, update_ticks=True):
# check if explitic ticks have been supplied
if self._ticks is None:
cbook._warn_external('To set explicit ticklabels, call colorbar() '
'with ticks keyword or use set_ticks() method '
'first.')
'with ticks keyword or use set_ticks() '
'method first.')
# check if length of ticks and ticklabels match
elif len(self._ticks) != len(self._ticklabels):
cbook._warn_external('The ticklabels need to be of the same '
Expand All @@ -744,8 +744,8 @@ def set_ticklabels(self, ticklabels, update_ticks=True):
else:
cbook._warn_external('To set ticklabels, ticks of the same '
'length need to be set explicitly first. '
'This can be done through plt.colorbar(ticks) '
'or set_ticks().')
'This can be done through '
'plt.colorbar(ticks) or set_ticks().')
self.stale = True

def minorticks_on(self):
Expand Down