Skip to content

Add getters and _repr_html_ for over/under/bad values of Colormap objects. #17900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timhoffm merged 20 commits into from
Aug 19, 2020
Merged

Add getters and _repr_html_ for over/under/bad values of Colormap objects. #17900

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
924aa61
Add get_bad, get_under, get_over.
bdice Jul 12, 2020
c7115f0
Add missing docstring to is_gray.
bdice Jul 12, 2020
2fd8ed0
Add under/over/bad colors to Colormap _repr_html_.
bdice Jul 12, 2020
4514171
Add tests for getters.
bdice Jul 12, 2020
90dc80e
Add What's New.
bdice Jul 12, 2020
8dcb3ea
Fix flake8, reorder words.
bdice Jul 12, 2020
c6fc989
Use same_color for testing.
bdice Jul 13, 2020
feb1f87
Apply suggestions from code review
bdice Jul 12, 2020
642477e
Use values outside [0, 1] for testing under/over.
bdice Jul 13, 2020
c43cceb
Remove reference to norm.clip in docstrings.
bdice Jul 14, 2020
9ca1893
Move under/bad/over below the colormap.
bdice Aug 9, 2020
12fd588
Apply CSS suggestions from @greglucas.
bdice Aug 10, 2020
df1cd26
Fix references to documentation.
bdice Aug 10, 2020
64faef0
Use max-width to make content more responsive.
bdice Aug 10, 2020
a55cbf7
Use one line for short docstrings.
bdice Aug 16, 2020
5b095f9
Use f-strings and implicit continuations.
bdice Aug 16, 2020
4581ab8
Use private module constant for PNG representation size.
bdice Aug 16, 2020
057dc55
Improve HTML repr tests.
bdice Aug 16, 2020
e398f92
Assert base64 encoded png is in HTML representation.
bdice Aug 16, 2020
977677a
Fix flake8.
bdice Aug 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use max-width to make content more responsive.
  • Loading branch information
@bdice
bdice committed Aug 10, 2020
commit 64faef05ea29abcc4a30a53ef28f719fffbae1e5
2 changes: 1 addition & 1 deletion lib/matplotlib/colors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,7 @@ def color_block(color):
'title="' + self.name + '" ' +
'style="border: 1px solid #555;" ' +
'src="data:image/png;base64,' + png_base64 + '"></div>' +
'<div style="vertical-align: middle; width: 402px; ' +
'<div style="vertical-align: middle; max-width: 402px; ' +
Comment thread
bdice marked this conversation as resolved.
Outdated
'display: flex; justify-content: space-between;">' +
'<div style="float: left;">' +
color_block(self.get_under()) + ' under' +
Expand Down