Repository navigation
Fix missing attribute in _SVGConverter. - #17210
Merged
Merged
Conversation
tacaswell
approved these changes
Apr 22, 2020
tacaswell
left a comment
tacaswell
left a comment
Member
There was a problem hiding this comment.
I'm fine with this going in without a test as it is a bug in the code path raised on an failed test.
QuLogic
approved these changes
Apr 22, 2020
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon! If these instruction are inaccurate, feel free to suggest an improvement. |
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
May 6, 2020
Fix missing attribute in _SVGConverter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
I broke this accidentally in https://github.com/matplotlib/matplotlib/pull/9454/files#diff-3ccb29855c353a5da7c4525f9bed826aL193 (so a while ago already and noone noticed...) and now it's breaking the mplcairo CI :)
PR Checklist