Repository navigation
Use more _setattr_cm, thus fix Text('').get_window_extent(dpi=...) - #16828
Merged
Merged
Conversation
timhoffm
reviewed
Mar 19, 2020
timhoffm
approved these changes
Mar 22, 2020
This special case does not correctly reset the figure dpi, so the figure randomly gets bigger when it's called. This does not affect Text with actual content.
anntzer
approved these changes
Mar 25, 2020
Member
Author
|
The AppVeyor failure in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This adds more
_setattr_cm, and fixes a bug inText.get_window_extentwhere if it contained an empty string, it would not reset the dpi of the figure.PR Checklist