Repository navigation
Add titlecolor in rcParams - #14707
Conversation
|
As had been commented already by @timhoffm, it might be beneficial to introduce a new |
|
Should only |
|
Good question. I do not have an opinion on that. Since we do have |
|
How does this look? I tried to check the behaviour of some other parameters that had an I was also wondering if it would be a good idea to add a call to |
|
I think it is ready for review, and unless there are any more requests, merging too. |
|
I am 50/50 on using the string "auto" as a sentinel. On one hand it is slightly ambiguous with the string color names, on the other hand we already have precedent for this and using |
|
Whichever you prefer. It won't be difficult to change. I can leave you some time to discuss it and agree on one alternative for the fallback, just let me know and I will use the chosen one. |
|
@tacaswell @ImportanceOfBeingErnest Should I modify the sentinel to |
|
There are plenty of "None"s in the rc files, so I think its a good convention for "fall back on a default" |
|
I was changing the code to use It could be something different than |
|
Can someone rerun the docs tests? They failed in the installation section: It does not look related to my PR |
|
Can you try a rebase? I think there was a problem with CI that was fixed recently.... I think you just need to do: assuming you have the upstream branch setup https://matplotlib.org/3.1.0/devel/gitwash/development_workflow.html |
|
Anything else left to do? Maybe add |
|
PRs need two approvals to be merged. |
|
Thanks, and congratulations on your first contribution to Matploblib! Hope to see you back some time. |
PR Summary
Extremely simple solution to #14656. I am not sure if this follows the direction you had in mind, I am open to add an extra parameter to rcparams as discussed in the issue, extend (or not) this behaviour to
suptitle.PR Checklist