Skip to content

Warn in colorbar() when mappable.axes != figure.gca(). #12443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuLogic merged 2 commits into from
Jul 18, 2020
Merged

Warn in colorbar() when mappable.axes != figure.gca(). #12443

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
825c242
Warn in colorbar() when mappable.axes != figure.gca().
anntzer Oct 8, 2018
fa96f30
Also warn in pyplot.colorbar (by falling back to Figure.colorbar).
anntzer Jul 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Also warn in pyplot.colorbar (by falling back to Figure.colorbar).
  • Loading branch information
@anntzer
anntzer committed Jul 6, 2020
commit fa96f30d221cc4124194c1d8acebc8c5390bb9bb
14 changes: 7 additions & 7 deletions doc/api/next_api_changes/deprecations/12443-AL.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
Figure.colorbar now warns when the mappable's axes is different from the current axes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
``colorbar`` now warns when the mappable's axes is different from the current axes
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Currently, `.Figure.colorbar` steals space by default from the current axes
to place the colorbar. In a future version, it will steal space from the
mappable's axes instead. In preparation for this change, `.Figure.colorbar`
now emits a warning when the current axes is not the same as the mappable's
axes.
Currently, `.Figure.colorbar` and `.pyplot.colorbar` steal space by default
from the current axes to place the colorbar. In a future version, they will
steal space from the mappable's axes instead. In preparation for this change,
`.Figure.colorbar` and `.pyplot.colorbar` now emits a warning when the current
axes is not the same as the mappable's axes.
2 changes: 0 additions & 2 deletions lib/matplotlib/pyplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2181,8 +2181,6 @@ def colorbar(mappable=None, cax=None, ax=None, **kw):
'creation. First define a mappable such as '
'an image (with imshow) or a contour set ('
'with contourf).')
if ax is None:
ax = gca()
ret = gcf().colorbar(mappable, cax=cax, ax=ax, **kw)
return ret

Expand Down