Repository navigation
[MRG] Optimize 3D display (continued) #11577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
2a75026
Optimize 3D display (#6085)
AlexandreAbraham b168bed
Remove irrelevant changes
rth a3c331d
Fix undefined variables
rth a5c2bd5
Check diff with respect to the original PR
rth e955f56
Address some review comments
rth e227b50
Make _juggle_axes_vec and _rotate_axes_vec private
rth ee53be5
Address review comments
rth 8244c07
Make TestVoxels.test_rgb_data pass
rth 677e79b
Review comment - use np.split + np.cumsum
rth d095d26
Fix broadcasting
rth 005f6fb
PEP8
rth f74f3d7
Better debug message
rth dda0f82
Merge branch 'master' into optimize_3d
rth 1c1e4a1
Fix for numpy 1.10
rth 7a5c50d
Merge branch 'optimize_3d' of github.com:rth/matplotlib into optimize_3d
rth 7c2c22e
Ignore flake8 exception and code clean-up
rth b81c118
Fix sphinx build
rth 822f4f7
More review comments
rth 004fff2
Fix PEP8
rth f7795e0
Address part of Eric's comments
rth da7f72c
Fix anntzer's comments
rth 17657a4
Address Benjamin's review comments
rth e43b930
Minor fixes
rth 7211708
Removing _juggle_axes_vec and _rotate_axes_vec
rth 5bfa368
Remove flake8 E231 ignore for art3d.py
rth 5faaa0c
Addressed more eric-weiser's comments
rth 7631cfe
Convert _seg_sizes to array
rth ad0e783
Handle empty sequences
rth 98d1161
Address review comments
rth 1696d52
Experimentally revert get_colors to the previous behaviour
rth 867819f
Merge branch 'master' into optimize_3d
rth 92daa11
Merge branch 'master' into optimize_3d
rth a268fc7
Fix merge issue
rth 946b9bc
Fix more merge conflicts
rth ff18f5f
Lint
rth 76d5dc7
Fix one test failure
rth 3e230c7
Address comments
rth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove irrelevant changes
- Loading branch information
commit b168bed10c7560a519e4241bf56af554726e0b8c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a typo, I think