Skip to content

Expose URLLIB connection pool KW #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romanzdk wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Expose URLLIB connection pool KW #1008

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1932f2
Expose URLLIB connection pool KW
Mar 18, 2026
9ddf5ff
Fix tests and other stuff
Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix tests and other stuff
  • Loading branch information
Roman Zydyk
Roman Zydyk committed Mar 18, 2026
commit 9ddf5ff487cd5b2df21379354818f2ec5e12c656
3 changes: 1 addition & 2 deletions massive/rest/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from typing_extensions import Dict
from .aggs import AggsClient
from .futures import FuturesClient
from .financials import FinancialsClient
Expand All @@ -21,7 +20,7 @@
ContractsClient,
)
from .vX import VXClient
from typing import Optional, Any
from typing import Optional, Any, Dict
import os

BASE = "https://api.massive.com"
Expand Down
4 changes: 1 addition & 3 deletions massive/rest/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,7 @@ def __init__(
cert_reqs="CERT_REQUIRED",
retries=retry_strategy, # use the customized Retry instance
timeout=self.timeout, # set timeout for each request
connection_pool_kw=connection_pool_kw
if connection_pool_kw is not None
else {},
**(connection_pool_kw if connection_pool_kw is not None else {}),
)

if verbose:
Expand Down
36 changes: 36 additions & 0 deletions test_rest/test_connection_pool_kw.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
import sys
import os

sys.path.insert(0, os.path.dirname(__file__))

import unittest
from unittest.mock import patch, MagicMock
from massive import RESTClient


class ConnectionPoolKwTest(unittest.TestCase):
def _make_client(self, **kwargs):
with patch("urllib3.PoolManager") as mock_pm:
mock_pm.return_value = MagicMock()
RESTClient(api_key="test", **kwargs)
return mock_pm

def test_default_no_extra_kwargs(self):
"""connection_pool_kw=None passes no extra kwargs to PoolManager."""
mock_pm = self._make_client()
_, call_kwargs = mock_pm.call_args
self.assertNotIn("connection_pool_kw", call_kwargs)

def test_connection_pool_kw_passed_as_kwargs(self):
"""connection_pool_kw dict is unpacked into PoolManager as kwargs."""
extra = {"maxsize": 20, "block": True}
mock_pm = self._make_client(connection_pool_kw=extra)
_, call_kwargs = mock_pm.call_args
self.assertEqual(call_kwargs["maxsize"], 20)
self.assertEqual(call_kwargs["block"], True)

def test_empty_connection_pool_kw(self):
"""Empty dict connection_pool_kw adds no extra kwargs to PoolManager."""
mock_pm = self._make_client(connection_pool_kw={})
_, call_kwargs = mock_pm.call_args
self.assertNotIn("connection_pool_kw", call_kwargs)
Loading