fix(ui): prevent document-wide select all - #958
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cmd/Ctrl+A outside a text field could select application labels, headers, and controls across the entire window. Cancel Chromium's document-wide
selectstartevent in the app root, covering both the keyboard shortcut and native Edit → Select All without changing editor keymaps or CSS selection.Validation: scoped ESLint and diff checks passed. Real Electron QA on macOS confirmed that global UI selection is blocked while native inputs, contenteditable fields, CodeMirror selection, and manual word selection in the HTTP preview remain functional. Windows/Linux were not tested. This does not add local Select All behavior to read-only HTTP viewers.
Closes #950