Skip to content

P0: make ARStack Studio shutdown deterministic on Windows #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
masarray wants to merge 10 commits into from
Closed

P0: make ARStack Studio shutdown deterministic on Windows #99

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3571c44
chore: stage Studio graceful-shutdown hardening
masarray Sep 15, 2026
ee4d2e8
chore: replace brittle shutdown staging helper
masarray Sep 15, 2026
6e88467
chore: stage bounded Studio lifecycle ownership
masarray Sep 15, 2026
7f0f736
chore: harden shutdown staging matcher
masarray Sep 15, 2026
ab3ad94
chore: stage final Studio lifecycle hardening
masarray Sep 15, 2026
75e5f2d
fix(studio): retire workers before GUI event loop exits
github-actions[bot] Sep 15, 2026
9c40c7a
chore: remove temporary lifecycle staging workflows
masarray Sep 15, 2026
bac361c
ci(studio): prove Windows close exit and immediate reopen
masarray Sep 15, 2026
d667ab9
ci(studio): fix PowerShell 5.1 lifecycle gate interpolation
masarray Sep 15, 2026
dbb564e
ci(studio): use native process exit contract for Windows GUI lifecycle
masarray Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: harden shutdown staging matcher
  • Loading branch information
@masarray
masarray committed Sep 15, 2026
commit 7f0f736389e8c3f58997c96dfb35391df0b2e4b6
39 changes: 39 additions & 0 deletions .github/workflows/fix-stage-graceful-shutdown.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: Fix graceful shutdown staging matcher

on:
push:
branches:
- fix/studio-graceful-shutdown-p0

permissions:
contents: write

jobs:
fix:
if: github.actor != 'github-actions[bot]'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
ref: fix/studio-graceful-shutdown-p0
fetch-depth: 0
- name: Replace brittle main-window anchor with structural regex
shell: python
run: |
from pathlib import Path
p = Path('.github/workflows/stage-studio-graceful-shutdown-v2.yml')
text = p.read_text(encoding='utf-8')
old = " replace_once('apps/arstack_studio/src/main.cpp', anchor, coordinator)\n"
new = """ regex_once(\n 'apps/arstack_studio/src/main.cpp',\n r' PrimaryWindowCloseFilter primaryCloseFilter\\{&app\\};\\n if \\(mainWindow != nullptr\\) \\{\\n mainWindow->installEventFilter\\(&primaryCloseFilter\\);\\n \\}\\n(?:\\n)?',\n coordinator)\n"""
if text.count(old) != 1:
raise SystemExit(f'expected one main-window anchor call, got {text.count(old)}')
p.write_text(text.replace(old, new, 1), encoding='utf-8')
- name: Commit matcher hardening
shell: bash
run: |
set -euo pipefail
git config user.name 'github-actions[bot]'
git config user.email '41898282+github-actions[bot]@users.noreply.github.com'
git add .github/workflows/stage-studio-graceful-shutdown-v2.yml
git commit -m 'chore: use structural matcher for shutdown coordinator staging'
git push origin HEAD:fix/studio-graceful-shutdown-p0
Loading