Repository navigation
PTP: ship hardware-timestamped timing engine in v0.1.1 production firmware - #98
Merged
Merged
Conversation
masarray
marked this pull request as ready for review
September 17, 2026 10:08
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Promote the already-implemented ARIEC61850/ARSVIN-derived PTP P1/P1.5/P1.75/P2 stack into the normal ARStack Studio / ESP32-P4 production firmware instead of shipping it compiled out.
This does not introduce a second PTP engine. It productizes the existing portable C++ engine, ESP32-P4 IEEE1588 hardware timestamp adapter, measured TIME_RECEIVER discipline path, MONITOR role, and existing Studio PTP Expert controls.
Production v0.1.1 contract
0.1.1.sdkconfig.defaultsenablesCONFIG_AR_PTP_LAB_TX=y.LAB_SOURCE.PTP-P2+SMPSYNCH-AUTO.Timing architecture retained
LAB_SOURCE: Announce + hardware-timestamped two-step Sync/Follow_Up + Pdelay response.TIME_RECEIVER: hardware RX/TX timestamp correlation, peer-delay, offset measurement, bounded clock discipline, LOCK/HOLDOVER state.MONITOR: passive observation.smpSynch truth boundary
PTP packet transmission alone is not a synchronization claim. In
LAB_SOURCE/MONITOR, AUTO remainssmpSynch=0. Only measuredTIME_RECEIVERdiscipline may promote AUTO to 1/2 under the existing P2 evidence policy. Forced 0/1/2 remain explicit lab stimuli.Isolation
No
apps/ied_simulator/**source or IED Simulator PR branch is changed by this integration. PR #75/#82 remain independent.Merge gate
Physical closeout is deliberately product-focused; this PR does not claim GPS traceability, certified grandmaster behavior, or formal IEEE 1588 / IEC 61850-9-3 conformance.